Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workspaces impacted by provider deletion #340

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Conversation

peppescg
Copy link
Collaborator

Show the list of workspaces impacted by provider deletion, in this way the user can have a bit of context.
I thought that the badge can work, but I would fine tune later with James.

Screenshot 2025-02-20 at 10 53 13

nit: We already that the table will be replaced, we are going to show the workspaces list and the models, and James is thinking on a different component. For that reason I would avoid to add test right now.

@peppescg peppescg self-assigned this Feb 20, 2025
@peppescg peppescg linked an issue Feb 20, 2025 that may be closed by this pull request
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13432755032

Details

  • 4 of 16 (25.0%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.5%) to 69.399%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/api/generated/sdk.gen.ts 1 2 50.0%
src/features/providers/components/workspaces-by-provider.tsx 0 1 0.0%
src/features/providers/hooks/use-confirm-delete-provider.tsx 0 1 0.0%
src/api/generated/@tanstack/react-query.gen.ts 3 6 50.0%
src/features/providers/components/table-providers.tsx 0 3 0.0%
src/features/providers/hooks/use-query-workspaces-by-provider.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/features/providers/components/table-providers.tsx 1 14.29%
src/features/providers/hooks/use-confirm-delete-provider.tsx 1 0.0%
Totals Coverage Status
Change from base Build 13411132463: -0.5%
Covered Lines: 851
Relevant Lines: 1166

💛 - Coveralls

@peppescg peppescg merged commit 5c0544f into main Feb 20, 2025
7 of 8 checks passed
@peppescg peppescg deleted the issues/302 branch February 20, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Show workspaces currently using provider
3 participants