Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: id format for provider, model muxing rule #360

Merged
merged 3 commits into from
Mar 3, 2025
Merged

fix: id format for provider, model muxing rule #360

merged 3 commits into from
Mar 3, 2025

Conversation

peppescg
Copy link
Collaborator

@peppescg peppescg commented Mar 3, 2025

Replaced id muxing dropdown using @ rather than : and replace the split logic using indexOf returning everything after separator as model name. The : is used by Ollama model. Actually the providers are using different model name format, we would thing to add a model_id for fix this.

Screenshot 2025-03-03 at 09 27 22

@peppescg peppescg self-assigned this Mar 3, 2025
@coveralls
Copy link
Collaborator

coveralls commented Mar 3, 2025

Pull Request Test Coverage Report for Build 13626612610

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 69.56%

Totals Coverage Status
Change from base Build 13540948529: -0.06%
Covered Lines: 864
Relevant Lines: 1178

💛 - Coveralls

@aponcedeleonch aponcedeleonch linked an issue Mar 3, 2025 that may be closed by this pull request
aponcedeleonch
aponcedeleonch previously approved these changes Mar 3, 2025
@peppescg
Copy link
Collaborator Author

peppescg commented Mar 3, 2025

Changed the actions/cache due actions/cache#1510

@peppescg peppescg requested a review from aponcedeleonch March 3, 2025 08:36
@peppescg peppescg enabled auto-merge (squash) March 3, 2025 08:37
@peppescg peppescg linked an issue Mar 3, 2025 that may be closed by this pull request
@peppescg peppescg merged commit 3cff061 into main Mar 3, 2025
7 of 8 checks passed
@peppescg peppescg deleted the issues/359 branch March 3, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ollama formatting model name mismatch Muxing rule errors with Ollama
3 participants