Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement server side pagination in frontend #368

Merged
merged 17 commits into from
Mar 11, 2025

Conversation

alex-mcgovern
Copy link
Collaborator

@alex-mcgovern alex-mcgovern commented Mar 4, 2025

Handles the API changes from:

Relates to stacklok/codegate#1020

Something important to call out is the backend doesn't support search/filtering by substring — I'm tracking this separately: [Task]: Investigate feasability of filtering workspace messages by substring in prompt

There is also some extra testing that can be done around the pagination UX, also tracked separately: [Task]: Follow up integration tests for messages pagination

@alex-mcgovern alex-mcgovern changed the title fix: server side pagination fix: implement server side pagination in frontend Mar 4, 2025
@alex-mcgovern alex-mcgovern marked this pull request as ready for review March 5, 2025 11:58
@coveralls
Copy link
Collaborator

coveralls commented Mar 5, 2025

Pull Request Test Coverage Report for Build 13786985073

Details

  • 107 of 164 (65.24%) changed or added relevant lines in 20 files are covered.
  • 13 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-3.4%) to 66.498%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/api/generated/sdk.gen.ts 9 14 64.29%
src/features/dashboard-messages/hooks/use-messages-filter-search-params.ts 6 11 54.55%
src/features/dashboard-messages/components/table-messages-pagination.tsx 5 13 38.46%
src/api/generated/@tanstack/react-query.gen.ts 24 63 38.1%
Files with Coverage Reduction New Missed Lines %
src/api/generated/sdk.gen.ts 1 66.9%
src/constants/empty-state-strings.ts 1 25.0%
src/mocks/msw/handlers.ts 1 74.07%
src/api/generated/@tanstack/react-query.gen.ts 4 59.5%
src/features/dashboard-messages/hooks/use-messages-filter-search-params.ts 6 51.35%
Totals Coverage Status
Change from base Build 13766424035: -3.4%
Covered Lines: 896
Relevant Lines: 1276

💛 - Coveralls

@alex-mcgovern alex-mcgovern merged commit b730c4a into main Mar 11, 2025
6 of 8 checks passed
@alex-mcgovern alex-mcgovern deleted the fix/server-side-pagination branch March 11, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants