Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore]: define dashboard api base url using docker env #1229

Closed
peppescg opened this issue Mar 5, 2025 · 0 comments · Fixed by #1231
Closed

[Chore]: define dashboard api base url using docker env #1229

peppescg opened this issue Mar 5, 2025 · 0 comments · Fixed by #1231
Assignees

Comments

@peppescg
Copy link
Contributor

peppescg commented Mar 5, 2025

Description

In order to allow the users to specify the dashboard base api url (by default it is http://localhost:8989) we can add a docker env DASHBOARD_API_BASE_URL that the users can use to set dashboard api base url in the UI.
Rather than using sed for replace the env var in the js file, we can use envsubst through the index.html that includes the env var used in the UI for handle the API requests.

Additional Context

Discord thread

@peppescg peppescg self-assigned this Mar 5, 2025
@peppescg peppescg linked a pull request Mar 5, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant