New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new toOpenarray #8

Open

mratsim opened this issue May 19, 2018 · 0 comments

Contributor

mratsim commented May 19, 2018

Some allocations can be avoided by using toOpenarray instead of slicing, for example:

nim-ethash/src/proof_of_work.nim

Line 175 in 66d7fb6

    
           s = keccak_512 s_bytes[][0..<40]                  # TODO: Does this allocate a seq?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment