Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange dependency tree #25

Closed
mratsim opened this issue Jan 7, 2021 · 3 comments
Closed

Strange dependency tree #25

mratsim opened this issue Jan 7, 2021 · 3 comments

Comments

@mratsim
Copy link
Contributor

mratsim commented Jan 7, 2021

I'm not sure why nim-json-serialization depends on BearSSL or Chronos, that seems very wrong.

image
@mratsim mratsim mentioned this issue Jan 7, 2021
Open
@SolitudeSF
Copy link

faststreams has chronos integration

@mratsim
Copy link
Contributor Author

mratsim commented Jan 8, 2021

I think faststreams is lower level than Chronos so:

  • either we have optional dependencies in nimble and faststreams optionally depend on Chronos
  • or chronos depends on faststreams, and the faststreams integration is built directly in Chronos. Which will be needed for async channels in any case [WIP]: AsyncChannels[T]. nim-chronos#45

@mratsim mratsim mentioned this issue Feb 9, 2021
Merged
@jangko
Copy link
Contributor

jangko commented Dec 4, 2023

fixed by status-im/nim-faststreams#38, closing

@jangko jangko closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jangko @SolitudeSF @mratsim