unit-tests: Reset to non-blocking mode after build

HACK: Before running the tests we need to make sure stdio is in
blocking mode. We have not yet been able to figure out what is
putting it non-blocking.

Closes cockpit-project#9469

Author: stefwalter

containers/unit-tests/run.sh

@@ -3,6 +3,10 @@
 set -o pipefail
 set -eux
 
+# HACK: Something invoked by our build system is setting stdio to non-blocking.
+# Validate that this isn't the surrounding context. See more below.
+python -c "import fcntl, os; assert fcntl.fcntl(0, fcntl.F_GETFL) & os.O_NONBLOCK == 0; assert fcntl.fcntl(1, fcntl.F_GETFL) & os.O_NONBLOCK == 0; assert fcntl.fcntl(2, fcntl.F_GETFL) & os.O_NONBLOCK == 0"
+
 # copy host's source tree to avoid changing that, and make sure we have a clean tree
 if [ ! -e /source/.git ]; then
     echo "This container must be run with --volume <host cockpit source checkout>:/source:ro" >&2
@@ -25,18 +29,22 @@ case $ARCH in
         exit 1
 esac
 
-${CC:-gcc} ./tools/careful-cat.c -o careful-cat
 ./autogen.sh --prefix=/usr --enable-strict --with-systemdunitdir=/tmp
-make -j2 V=1 all
+
+make V=1 all
+
+# HACK: Before running the tests we need to make sure stdio is in blocking mode. We have
+# not yet been able to figure out what is putting it non-blocknig.
+python -c "import fcntl, os; map(lambda fd: fcntl.fcntl(fd, fcntl.F_SETFL, fcntl.fcntl(fd, fcntl.F_GETFL) &~ os.O_NONBLOCK), [0, 1, 2])"
 
 # only run distcheck on main arch
 if [ "$ARCH" = amd64 ]; then
-    make -j8 distcheck 2>&1 | ./careful-cat
+    make -j8 distcheck 2>&1
 else
-    make -j8 check 2>&1 | ./careful-cat
+    make -j8 check 2>&1
 fi
 
-make -j8 check-memory 2>&1 | ./careful-cat || {
-    ./careful-cat test-suite.log
+make -j8 check-memory 2>&1 || {
+    cat test-suite.log
     exit 1
 }