Skip to content

Add an eviction / restoration integration test #5613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tamirms opened this issue Feb 25, 2025 · 1 comment
Open

Add an eviction / restoration integration test #5613

tamirms opened this issue Feb 25, 2025 · 1 comment

Comments

@tamirms
Copy link
Contributor

tamirms commented Feb 25, 2025

We have integration tests which exercise expiration and restoration of contract asset balances. However, these integration tests do not exercise eviction of contract data ledger entries because eviction is only implemented in protocol 23.

Once we have a protocol 23 enabled stellar rpc docker image we should add a horizon integration test which evicts a contract asset balance and asserts the /assets response works as expected. The test should also attempt to restore the evicted contract asset balance and assert the /assets response now includes the restored contract asset balance.

@urvisavla
Copy link
Contributor

urvisavla commented Apr 9, 2025

I tried using p-23 stellar-rpc docker image @Shaptic shared internally but I wasn’t able to run the Horizon SAC integration tests for protocol 23.

After checking with @2opremio, it turns out the rpc simulation library needs to be updated to support p-23 which depends on an updated soroban-rust-env and that isn’t available yet.

I’m moving this ticket to blocked for now, since we need p-23 support in RPC to create contracts with eviction metadata (which is only available starting in p-23).

However, there are a few config flags needed for testing eviction that can be added now and I’ll do that in a separate PR.

@urvisavla urvisavla moved this from In Progress to Blocked in Platform Scrum Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

No branches or pull requests

3 participants