Skip to content

Commit 64cbdf9

Browse files
committed
update logic to set up eslint on init
1 parent 3759fba commit 64cbdf9

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Diff for: code/lib/create-storybook/src/generators/baseGenerator.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -351,18 +351,13 @@ export async function baseGenerator(
351351
text: `Getting the correct version of ${packagesToInstall.length} packages`,
352352
}).start();
353353

354-
const versionedPackages = await packageManager.getVersionedPackages(
355-
packagesToInstall as string[]
356-
);
357-
versionedPackagesSpinner.succeed();
358-
359354
try {
360355
if (process.env.CI !== 'true') {
361356
const { hasEslint, isStorybookPluginInstalled, isFlatConfig, eslintConfigFile } =
362357
await extractEslintInfo(packageManager);
363358

364359
if (hasEslint && !isStorybookPluginInstalled) {
365-
versionedPackages.push('eslint-plugin-storybook');
360+
packagesToInstall.push('eslint-plugin-storybook');
366361
await configureEslintPlugin({
367362
eslintConfigFile,
368363
packageManager,
@@ -374,6 +369,11 @@ export async function baseGenerator(
374369
// any failure regarding configuring the eslint plugin should not fail the whole generator
375370
}
376371

372+
const versionedPackages = await packageManager.getVersionedPackages(
373+
packagesToInstall as string[]
374+
);
375+
versionedPackagesSpinner.succeed();
376+
377377
if (versionedPackages.length > 0) {
378378
const addDependenciesSpinner = ora({
379379
indent: 2,

0 commit comments

Comments
 (0)