Skip to content

Commit aa4547d

Browse files
authored
Merge pull request #25476 from storybookjs/yann/remove-deprecated-framework-types
Types: Remove Framework in favor of Renderer types
2 parents 656adbe + 7acfd6d commit aa4547d

File tree

9 files changed

+5
-35
lines changed

9 files changed

+5
-35
lines changed

MIGRATION.md

+5
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
- [props from WithTooltipComponent from @storybook/components](#props-from-withtooltipcomponent-from-storybookcomponents)
3535
- [LinkTo direct import from addon-links](#linkto-direct-import-from-addon-links)
3636
- [DecoratorFn, Story, ComponentStory, ComponentStoryObj, ComponentStoryFn and ComponentMeta TypeScript types](#decoratorfn-story-componentstory-componentstoryobj-componentstoryfn-and-componentmeta-typescript-types)
37+
- ["Framework" TypeScript types](#framework-typescript-types)
3738
- [From version 7.5.0 to 7.6.0](#from-version-750-to-760)
3839
- [CommonJS with Vite is deprecated](#commonjs-with-vite-is-deprecated)
3940
- [Using implicit actions during rendering is deprecated](#using-implicit-actions-during-rendering-is-deprecated)
@@ -628,6 +629,10 @@ The `DecoratorFn` type is now removed in favor of `Decorator`. [More info](#rena
628629

629630
For React, the `ComponentStory`, `ComponentStoryObj`, `ComponentStoryFn` and `ComponentMeta` types are now removed in favor of `StoryFn`, `StoryObj` and `Meta`. [More info](#componentstory-componentstoryobj-componentstoryfn-and-componentmeta-types-are-deprecated).
630631

632+
#### "Framework" TypeScript types
633+
634+
The Framework types such as `ReactFramework` are now removed in favor of Renderer types such as `ReactRenderer`. This affects all frameworks. [More info](#renamed-xframework-to-xrenderer).
635+
631636
## From version 7.5.0 to 7.6.0
632637

633638
#### CommonJS with Vite is deprecated

code/frameworks/angular/src/client/types.ts

-4
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@ export interface StoryFnAngularReturnType {
3737
userDefinedTemplate?: boolean;
3838
}
3939

40-
/**
41-
* @deprecated Use `AngularRenderer` instead.
42-
*/
43-
export type AngularFramework = AngularRenderer;
4440
export interface AngularRenderer extends WebRenderer {
4541
component: any;
4642
storyResult: StoryFnAngularReturnType;

code/frameworks/ember/src/client/preview/types.ts

-4
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@ export interface OptionsArgs {
1313
element: any;
1414
}
1515

16-
/**
17-
* @deprecated Use `EmberRenderer` instead.
18-
*/
19-
export type EmberFramework = EmberRenderer;
2016
export interface EmberRenderer extends WebRenderer {
2117
component: any;
2218
storyResult: OptionsArgs;

code/renderers/html/src/types.ts

-4
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ export interface ShowErrorArgs {
1414
description: string;
1515
}
1616

17-
/**
18-
* @deprecated Use `HtmlRenderer` instead.
19-
*/
20-
export type HtmlFramework = HtmlRenderer;
2117
export interface HtmlRenderer extends WebRenderer {
2218
component: string | HTMLElement | ArgsStoryFn<HtmlRenderer>;
2319
storyResult: StoryFnHtmlReturnType;

code/renderers/preact/src/types.ts

-7
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,6 @@ export interface ShowErrorArgs {
1010
description: string;
1111
}
1212

13-
/**
14-
* @dep
15-
*/
16-
/**
17-
* @deprecated Use `PreactRenderer` instead.
18-
*/
19-
export type PreactFramework = PreactRenderer;
2013
export interface PreactRenderer extends WebRenderer {
2114
component: AnyComponent<any, any>;
2215
storyResult: StoryFnPreactReturnType;

code/renderers/react/src/types.ts

-4
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@ import type { WebRenderer } from '@storybook/types';
33

44
export type { RenderContext, StoryContext } from '@storybook/types';
55

6-
/**
7-
* @deprecated Use `ReactRenderer` instead.
8-
*/
9-
export type ReactFramework = ReactRenderer;
106
export interface ReactRenderer extends WebRenderer {
117
component: ComponentType<this['T']>;
128
storyResult: StoryFnReactReturnType;

code/renderers/server/src/types.ts

-4
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ export type { RenderContext } from '@storybook/types';
55
export type StoryFnServerReturnType = any;
66
export type StoryContext = StoryContextBase<ServerRenderer>;
77

8-
/**
9-
* @deprecated Use `ServerRenderer` instead.
10-
*/
11-
export type ServerFramework = ServerRenderer;
128
export interface ServerRenderer extends WebRenderer {
139
component: string;
1410
storyResult: StoryFnServerReturnType;

code/renderers/vue3/src/types.ts

-4
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ export type StoryContext = StoryContextBase<VueRenderer>;
1616

1717
export type StorybookVueApp = { vueApp: App<any>; storyContext: StoryContext };
1818

19-
/**
20-
* @deprecated Use `VueRenderer` instead.
21-
*/
22-
export type VueFramework = VueRenderer;
2319
export interface VueRenderer extends WebRenderer {
2420
// We are omitting props, as we don't use it internally, and more importantly, it completely changes the assignability of meta.component.
2521
// Try not omitting, and check the type errros in the test file, if you want to learn more.

code/renderers/web-components/src/types.ts

-4
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@ export type StoryFnHtmlReturnType =
1010

1111
export type StoryContext = StoryContextBase<WebComponentsRenderer>;
1212

13-
/**
14-
* @deprecated Use `WebComponentsRenderer` instead.
15-
*/
16-
export type WebComponentsFramework = WebComponentsRenderer;
1713
export interface WebComponentsRenderer extends WebRenderer {
1814
component: string;
1915
storyResult: StoryFnHtmlReturnType;

0 commit comments

Comments
 (0)