You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
abstract = {The pressure attenuation of moving shocks when they propagate in ducts is of great importance in a wide variety of applications, such as health, safety, and transportation. The objective of this research is to investigate the propagation of shock waves in ducts with roughness. The roughness is added in the form of grooves as in an existing experiment. Straight and branching ducts are considered in order to better understand the mechanisms causing attenuation of the shock and the physics behind the evolution of the complex wave patterns resulting from diffraction and reflection of the primary moving shock. A finite
7
+
volume numerical method is used and further validated for several test cases relevant to this study. The computed results are compared with experimental measurements in ducts with grooves. Good agreement between high resolution simulations and experiment is obtained for the shock speeds and complex wave patterns created by the grooves. Time histories of pressure at various locations, and shock strengths are presented and compared with measurements. Different groove geometries have been tested in the numerical simulation in
8
+
order to identify the shape that will better diminish shock strength. Animations of the computed results are shown to reveal salient features of the unsteady flowfield.},
9
+
language = {English},
10
+
booktitle = {Proceeding of 6th {European} {Conference} on {Computational} {Mechanics} ({ECCM} 6) and 7th {European} {Conference} on {Computational} {Fluid} {Dynamics} ({ECFD} 7)},
11
+
author = {{Mortazawy Mehdi}},
12
+
month = jun,
13
+
year = {2018},
14
+
keywords = {Shock, Shock Wave}
15
+
}
16
+
17
+
@inproceedings{mehdi_numerical_2019,
18
+
address = {San Diego},
19
+
title = {A {Numerical} {Investigation} of {Shock} {Wave} {Propagation} in {Ducts} with {Grooves}},
20
+
url = {https://doi.org/10.2514/6.2019-2152},
21
+
doi = {10.2514/6.2019-2152},
22
+
abstract = {Experimental investigations and numerical simulations of normal shock waves of different strengths propagating inside ducts with roughness are presented. The roughness is added in the form of grooves. Straight and branching ducts are considered in order to better explore the mechanisms causing attenuation of the shock and the physics behind the evolution of the complex wave patterns resulting from diffraction and reflection of the primary moving shock. A well-established finite volume numerical method is used and further validated for several test cases relevant to this study. The computed results are compared with experimental measurements in ducts with grooves. Good agreement between high resolution simulations and the experiment is obtained for the shock speeds and complex wave patterns created by the grooves. High frequency response time histories of pressure at various locations were recorded in the experiments. The recorded pressure histories and shock strengths were found in fair agreement with the two-dimensional simulation results as long as the shock stays in the duct. Overall, the physics of the interactions of the moving shock, the diffracted and reflected waves with the grooves are adequately captured in the high resolution simulations. Therefore, shocks propagating in ducts with different groove geometries have been simulated in order to identify the groove shape that diminishes shock strength.},
23
+
language = {English},
24
+
booktitle = {Proceedings of a meeting held 7-11 {January} 2019, {San} {Diego}, {California}, {USA}},
25
+
publisher = {AIAA},
26
+
author = {Mehdi, Mortazawy and Konstantinos, Kontis and John, Ekaterinaris},
title = {Numerical {Simulation} of {Shock} {Wave} {Propagation} in {Ducts} with {Grooves}},
37
+
copyright = {Public},
38
+
shorttitle = {Numerical {Simulation} of {Shock} {Wave} {Propagation} in {Ducts} with {Grooves}},
39
+
url = {https://commons.erau.edu/edt/389/},
40
+
abstract = {The pressure attenuation of moving shocks when they propagate in ducts, is of great importance in a wide variety of applications, such as health, safety, and transportation. The objective of this research is to simulate the propagation of shock waves in ducts with roughness. The roughness is added in the form of grooves as in an existing experiment. Different shapes are considered in order to better understand the physics behind the evolution of the complex shock patterns resulting from diffraction, reflection and refraction of the primary moving shock. The contribution of grooves and duct shape on these phenomena and pressure attenuation is investigated. The numerical method is validated through several test cases, and the results are compared against the theory and the experimental measurements. Good agreement between high resolution computations and the experiment is obtained for the shock speeds and complex wave patterns created by the grooves. Time histories of pressure at various locations are also compared. It is found that accurate pressure history agreement requires a close representation of the full experimental setup to fully capture boundary layer development, and pressure losses associated with unsteady moving shocks in long ducts. Different groove geometries have been tested in the numerical computation in order to identify the shape that will diminish shock strength, hence pressure extrema more effectively. Analysis and animations of the computed results are employed to reveal salient features of the unsteady flowfield.},
Copy file name to clipboardexpand all lines: _docs/Code-Review.md
+3-3
Original file line number
Diff line number
Diff line change
@@ -12,19 +12,19 @@ The goal of code review is to maintain correct code in a consistent style. Human
12
12
All developers and users (internal and external) are encouraged to participate in the code review process. The SU2 suite is a computational environment we are all working to maintain. When performing a code review, you should be asking yourself "Is this code that I want in our environment". A single developer may have written the bulk of the pull request, but once a change has been incorporated the whole community is in charge of future changes (maintenance, debugging, etc.). Questions you should ask yourself are
13
13
14
14
1. Is this a desirable change to the code base?
15
-
- Does it make code more legible?
15
+
- Does it make the code more legible?
16
16
- Add new features?
17
17
- Fix a bug?
18
18
19
19
2. Is the change implemented in the correct way?
20
20
- Does it interact minimally with the rest of the code?
21
21
- Does it have the correct algorithmic complexity?
22
-
- Is it located in the place? (file, etc.)
22
+
- Is it located in the right place? (file, etc.)
23
23
24
24
3. Is the code legible?
25
25
- Is the code mostly legible on its own without documentation?
26
26
- Are the variable names concise and accurate?
27
-
- Is there documentation where necessary, and it is correct?
27
+
- Is there documentation where necessary, and is it correct?
Copy file name to clipboardexpand all lines: _docs/Contact.md
+3-3
Original file line number
Diff line number
Diff line change
@@ -10,10 +10,10 @@ Users of SU2 who have questions not addressed in the User's Guide, Developer's G
10
10
If you find bugs or issues in the source code or would like to submit a feature request, please use the issue tracker on the SU2 GitHub page at: [https://github.com/su2code/SU2/issues](https://github.com/su2code/SU2/issues)
11
11
12
12
### SU2 User's Mailing List
13
-
Users are encouraged to join the SU2 user's email list. This list will be used to communicate important information to users such as new releases or event announcements. To join, follow the link below, enter your email address, and follow the directions for confirmation. Your email address will not be shared or used for anything except email communication from the development team.
13
+
Users are encouraged to join the SU2 user's email list. This list will be used to communicate important information to users such as new releases or event announcements. To join, follow the link below. We take privacy matters seriously - please see our privacy and cookie policies for more information.
14
14
15
-
[Join the List!](http://su2devsociety.org/su2-user-registration/)
15
+
[Join the List!](https://su2foundation.org/)
16
16
17
-
### Join the SU2 Developer Team
17
+
### Join the SU2 Development Team
18
18
19
19
All developers that would like to contribute to SU2 are encouraged to get involved on [GitHub](https://github.com/su2code/SU2). Whether you would like to share new features or fixes with the community through Pull Requests, report issues or feature requests, or discuss the latest with your fellow developers, your participation is most welcome!
Copy file name to clipboardexpand all lines: _docs/Cygwin-Build-for-Windows.md
+20-1
Original file line number
Diff line number
Diff line change
@@ -24,7 +24,7 @@ At the package selection step, search for the following terms and select the ass
24
24
* python: install the packages under the python sub-heading
25
25
* cpp: all debug, pre-processor, regular expression packages.
26
26
27
-
####Example SU2 installation on WINDOWS 10 using 64-bit Cygwin
27
+
### Example SU2 installation on WINDOWS 10 using 64-bit Cygwin
28
28
29
29
The CYGWIN `bash` shell is used for all steps on the command line. It is automatically available after the first installation step (typically to be launched via the CYGWIN desktop icon).
30
30
@@ -132,6 +132,13 @@ The CYGWIN `bash` shell is used for all steps on the command line. It is automat
132
132
./bootstrap
133
133
```
134
134
135
+
1. Set compiler flags (just to be sure not to use the debug option -g)
136
+
137
+
```bash
138
+
export CFLAGS='-O2'
139
+
export CXXFLAGS='-O2'
140
+
```
141
+
135
142
1. Create Makefiles:
136
143
137
144
> NOTE: didn't yet get `tecio` working, therefore disabled with `--disable-tecio`<br>
@@ -153,6 +160,18 @@ The CYGWIN `bash` shell is used for all steps on the command line. It is automat
153
160
make install
154
161
```
155
162
163
+
1. Reduce size of executables significantly (strip symbols, see also [CYGWIN FAQ 6.3](https://www.cygwin.com/faq.html). The SU2_CFD.exe is reduced from approx. 600MB to 15MB. Can be omitted if compiled with the -s option to gcc.
164
+
> NOTE: This should **NOT** be necessary if compiler flags are set as shown in step 7
165
+
```bash
166
+
make install-strip
167
+
```
168
+
169
+
1. Cleanup the installation. This removes also the intermediate big executables from the build folders.
170
+
171
+
```bash
172
+
make clean
173
+
```
174
+
156
175
1. Add the `$SU2_HOME` and `$SU2_RUN` environment variables to `~/.bashrc` (and `source ~/.bashrc`)
Copy file name to clipboardexpand all lines: _docs/Download.md
+1-1
Original file line number
Diff line number
Diff line change
@@ -5,5 +5,5 @@ permalink: /docs/Download/
5
5
6
6
SU2 is freely available for use under the GNU Lesser General Public License, version 2.1. Please reference the [license details](https://www.gnu.org/licenses/old-licenses/lgpl-2.1.en.html) for terms and conditions.
7
7
8
-
Please visit our [download portal](../../download.html) to obtain binary executables or the SU2 source code and [register as a user of SU2](http://su2devsociety.org/su2-user-registration/)!
8
+
Please visit our [download portal](../../download.html) to obtain binary executables or the SU2 source code and [register as a user of SU2](https://su2foundation.org/)!
Copy file name to clipboardexpand all lines: _docs/Gitting-Started.md
+2-2
Original file line number
Diff line number
Diff line change
@@ -9,8 +9,8 @@ As you now know, GitHub is the center of all development efforts in SU2. The su
9
9
10
10
We follow [a popular git branching strategy](http://nvie.com/posts/a-successful-git-branching-model/) in order to leverage decentralized development. This list describes the types of branches on the SU2 repository. You'll want to pick the right one to work with, in order keep the merging process simple.
11
11
12
-
- master -- stable, latest release and fixes </li>
13
-
- develop -- current development, generally the branch for you to fork or start a new branch from </li>
12
+
- master -- stable, latest release and fixes
13
+
- develop -- current development, generally the branch for you to fork or start a new branch from
14
14
- feature_* -- feature specific branches
15
15
- fix_* -- branches that fix a particular bug or capability (not new features)
0 commit comments