-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove options.externalDependencies? #77
Comments
@Rich-Harris we currently use this in our webpack build to watch files used in preprocessing which aren't directly imported into the codebase. At first glance I think #75 is a seperate issue. For example when preprocessing styles with postcss-load-config we supply svelte-loader with externalDependencies and any changes made to those deps will automatically update the build, otherwise it becomes very laborious manually restarting webpack. |
Interesting. Shouldn't the preprocessor still be responsible for declaring those dependencies? Or is that not possible? |
If there is a way to get CSS variables working via an @import in a Svelte <style> tag I don't mind whether its a preprocessor or external dependency. The only way we've managed to get it working currently is via svelte-loader -> postcss -> postcss-custom-properties -> external-dependencies. This is all to support IE11 so our CSS variables work 😥 |
Looking at this properly for the first time, and I'm not sure I understand how it's used: https://github.com/sveltejs/svelte-loader#external-dependencies
Is it something that can be removed now that we have #75?
cc @rob-balfre
The text was updated successfully, but these errors were encountered: