Skip to content

Commit 21360d9

Browse files
committed
improve test for issue#1685 messages from conversion v2 to v3
1 parent ac1c417 commit 21360d9

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

modules/swagger-parser/src/test/java/io/swagger/parser/OpenAPIParserTest.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package io.swagger.parser;
22

3-
import io.swagger.v3.core.util.Yaml;
43
import io.swagger.v3.oas.models.Components;
54
import io.swagger.v3.oas.models.OpenAPI;
65
import io.swagger.v3.oas.models.media.ArraySchema;
@@ -39,6 +38,10 @@ public void testNPE_1685() {
3938
options.setResolveFully(true);
4039
SwaggerParseResult swaggerParseResult = openAPIParser.readLocation("issue1685.json", null, options);
4140
assertNull(swaggerParseResult.getOpenAPI());
41+
assertNotNull(swaggerParseResult.getMessages());
42+
assertTrue(swaggerParseResult.getMessages().size() == 2);
43+
assertEquals(swaggerParseResult.getMessages().get(0), "attribute notswagger is unexpected");
44+
assertEquals(swaggerParseResult.getMessages().get(1), "attribute swagger is missing");
4245
}
4346

4447
@Test

pom.xml

+1-2
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@
394394
</repositories>
395395
<properties>
396396
<snakeyaml-version>1.30</snakeyaml-version>
397-
<swagger-parser-v2-version>1.0.58</swagger-parser-v2-version>
397+
<swagger-parser-v2-version>1.0.59-SNAPSHOT</swagger-parser-v2-version>
398398
<commons-io-version>2.11.0</commons-io-version>
399399
<slf4j-version>1.7.30</slf4j-version>
400400
<swagger-core-version>2.2.0-SNAPSHOT</swagger-core-version>
@@ -409,5 +409,4 @@
409409
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
410410
<sonatypeOssDistMgmtSnapshotsUrl>https://oss.sonatype.org/content/repositories/snapshots/</sonatypeOssDistMgmtSnapshotsUrl>
411411
</properties>
412-
413412
</project>

0 commit comments

Comments
 (0)