Merge pull request #1722 from swagger-api/issue1637

Fix for invalid location of style and explode when content is present

Author: gracekarina

modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/OpenAPIDeserializer.java

@@ -1655,19 +1655,8 @@ public Parameter getParameter(ObjectNode obj, String location, ParseResult resul
 			}
 		}
 
-		value = getString("style", obj, false, location, result);
-		setStyle(value, parameter, location, obj, result);
 
 
-		Boolean explode = getBoolean("explode", obj, false, location, result);
-		if (explode != null) {
-			parameter.setExplode(explode);
-		} else if (StyleEnum.FORM.equals(parameter.getStyle())) {
-			parameter.setExplode(Boolean.TRUE);
-		} else {
-			parameter.setExplode(Boolean.FALSE);
-		}
-
 
 		ObjectNode parameterObject = getObject("schema", obj, false, location, result);
 		if (parameterObject != null) {
@@ -1717,6 +1706,20 @@ else if(parameter.getSchema() == null) {
             result.missing(location,"content");
         }
 
+        value = getString("style", obj, false, location, result);
+        if (parameter.getContent() == null) {
+            setStyle(value, parameter, location, obj, result);
+
+            Boolean explode = getBoolean("explode", obj, false, location, result);
+            if (explode != null) {
+                parameter.setExplode(explode);
+            } else if (StyleEnum.FORM.equals(parameter.getStyle())) {
+                parameter.setExplode(Boolean.TRUE);
+            } else {
+                parameter.setExplode(Boolean.FALSE);
+            }
+        }
+
 		Map<String, Object> extensions = getExtensions(obj);
 		if (extensions != null && extensions.size() > 0) {
 			parameter.setExtensions(extensions);

modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIV3ParserTest.java

@@ -16,6 +16,7 @@
 import static org.testng.Assert.assertNull;
 import static org.testng.Assert.assertTrue;
 import static org.testng.Assert.fail;
+import static org.testng.AssertJUnit.assertNotSame;
 
 import java.io.File;
 import java.io.IOException;
@@ -31,10 +32,12 @@
 import java.util.Random;
 import java.util.Set;
 
+import io.swagger.v3.parser.util.DeserializationUtils;
 import io.swagger.v3.parser.util.SchemaTypeUtil;
 import org.apache.commons.io.FileUtils;
 import org.hamcrest.CoreMatchers;
 import org.testng.Assert;
+import org.testng.AssertJUnit;
 import org.testng.annotations.AfterClass;
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
@@ -85,6 +88,13 @@ public class OpenAPIV3ParserTest {
     protected int serverPort = getDynamicPort();
     protected WireMockServer wireMockServer;
 
+    @Test
+    public void testIssue1637_StyleAndContent() throws IOException {
+        ParseOptions options = new ParseOptions();
+        SwaggerParseResult result = new OpenAPIV3Parser().readLocation("src/test/resources/issue1637.yaml", null, options);
+        Yaml.prettyPrint(result.getOpenAPI());
+    }
+
     @Test
     public void testIssue1643_True() throws Exception{
         ParseOptions options = new ParseOptions();

modules/swagger-parser-v3/src/test/resources/issue1637.yaml

@@ -0,0 +1,23 @@
+openapi: 3.0.1
+info:
+  title: sample
+  version: "1.0"
+servers:
+  - url: www.abc.com
+paths:
+  /test:
+    get:
+      operationId: test
+      parameters:
+        - name: id
+          in: query
+          content:
+            application/json:
+              schema:
+                type: object
+                properties:
+                  a:
+                    type: string
+      responses:
+        200:
+          description: Ok