Skip to content

Commit d67f80a

Browse files
committed
[ORC] Fix more missing LLVMConsumeError calls.
1 parent 7fe1189 commit d67f80a

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

llvm/unittests/ExecutionEngine/Orc/OrcCAPITest.cpp

+10-4
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,8 @@ TEST_F(OrcCAPITestBase, MaterializationUnitCreation) {
213213
LLVMOrcMaterializationUnitRef MU = LLVMOrcAbsoluteSymbols(Pairs, 1);
214214
LLVMOrcJITDylibDefine(MainDylib, MU);
215215
LLVMOrcJITTargetAddress OutAddr;
216-
if (LLVMOrcLLJITLookup(Jit, &OutAddr, "test")) {
216+
if (LLVMErrorRef E = LLVMOrcLLJITLookup(Jit, &OutAddr, "test")) {
217+
LLVMConsumeError(E);
217218
FAIL() << "Failed to look up \"test\" symbol (triple = "
218219
<< TargetTriple << ")";
219220
}
@@ -231,7 +232,8 @@ TEST_F(OrcCAPITestBase, DefinitionGenerators) {
231232
nullptr);
232233
LLVMOrcJITDylibAddGenerator(MainDylib, Gen);
233234
LLVMOrcJITTargetAddress OutAddr;
234-
if (LLVMOrcLLJITLookup(Jit, &OutAddr, "test")) {
235+
if (LLVMErrorRef E = LLVMOrcLLJITLookup(Jit, &OutAddr, "test")) {
236+
LLVMConsumeError(E);
235237
FAIL() << "The DefinitionGenerator did not create symbol \"test\" "
236238
<< "(triple = " << TargetTriple << ")";
237239
}
@@ -253,11 +255,13 @@ TEST_F(OrcCAPITestBase, ResourceTrackerDefinitionLifetime) {
253255
LLVMOrcJITDylibCreateResourceTracker(MainDylib);
254256
LLVMOrcThreadSafeModuleRef TSM = createTestModule();
255257
if (LLVMErrorRef E = LLVMOrcLLJITAddLLVMIRModuleWithRT(Jit, RT, TSM)) {
258+
LLVMConsumeError(E);
256259
FAIL() << "Failed to add LLVM IR module to LLJIT (triple = "
257260
<< TargetTriple << ")";
258261
}
259262
LLVMOrcJITTargetAddress TestFnAddr;
260-
if (LLVMOrcLLJITLookup(Jit, &TestFnAddr, "sum")) {
263+
if (LLVMErrorRef E = LLVMOrcLLJITLookup(Jit, &TestFnAddr, "sum")) {
264+
LLVMConsumeError(E);
261265
FAIL() << "Symbol \"sum\" was not added into JIT (triple = "
262266
<< TargetTriple << ")";
263267
}
@@ -283,11 +287,13 @@ TEST_F(OrcCAPITestBase, ResourceTrackerTransfer) {
283287
LLVMOrcJITDylibCreateResourceTracker(MainDylib);
284288
LLVMOrcThreadSafeModuleRef TSM = createTestModule();
285289
if (LLVMErrorRef E = LLVMOrcLLJITAddLLVMIRModuleWithRT(Jit, DefaultRT, TSM)) {
290+
LLVMConsumeError(E);
286291
FAIL() << "Failed to add LLVM IR module to LLJIT (triple = "
287292
<< TargetTriple << ")";
288293
}
289294
LLVMOrcJITTargetAddress Addr;
290-
if (LLVMOrcLLJITLookup(Jit, &Addr, "sum")) {
295+
if (LLVMErrorRef E = LLVMOrcLLJITLookup(Jit, &Addr, "sum")) {
296+
LLVMConsumeError(E);
291297
FAIL() << "Symbol \"sum\" was not added into JIT (triple = "
292298
<< TargetTriple << ")";
293299
}

0 commit comments

Comments
 (0)