Skip to content

Commit 7f83594

Browse files
committedJan 21, 2020
Merge branch '4.4' into 5.0
* 4.4: [DI] Fix EnvVar not loaded when Loader requires an env var Fixed #34713 Move new messages to intl domain when possible [FrameworkBundle] Fix small typo in output comment chown and chgrp should also accept int as owner and group Revert "Fixed translations file dumper behavior" Fix RememberMe with null password [Validator] Fix plurals for sr_Latn (Serbian language written in latin script) validation messages Set booted flag to false when test kernel is unset [FrameworkBundle] remove messenger cache if not enabled [PhpUnitBridge][SymfonyTestsListenerTrait] Remove some unneeded code [HttpClient] Fix strict parsing of response status codes fix PHP const mapping keys using the inline notation [SecurityBundle] Drop duplicated code [FrameworkBundle] Make sure one can use fragments.hinclude_default_template Fix that no-cache requires positive validation with the origin, even for fresh responses Improve upgrading instructions for deprecated router options [DI] Suggest typed argument when binding fails with untyped argument
2 parents 227018a + 901b0c0 commit 7f83594

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed
 

‎Legacy/SymfonyTestsListenerTrait.php

-10
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ class SymfonyTestsListenerTrait
4040
private $expectedDeprecations = array();
4141
private $gatheredDeprecations = array();
4242
private $previousErrorHandler;
43-
private $reportUselessTests;
4443
private $error;
4544
private $runsInSeparateProcess = false;
4645

@@ -194,10 +193,6 @@ public function addSkippedTest($test, \Exception $e, $time)
194193
public function startTest($test)
195194
{
196195
if (-2 < $this->state && ($test instanceof \PHPUnit\Framework\TestCase || $test instanceof TestCase)) {
197-
if (null !== $test->getTestResultObject()) {
198-
$this->reportUselessTests = $test->getTestResultObject()->isStrictAboutTestsThatDoNotTestAnything();
199-
}
200-
201196
// This event is triggered before the test is re-run in isolation
202197
if ($this->willBeIsolated($test)) {
203198
$this->runsInSeparateProcess = tempnam(sys_get_temp_dir(), 'deprec');
@@ -243,11 +238,6 @@ public function endTest($test, $time)
243238
$className = \get_class($test);
244239
$groups = Test::getGroups($className, $test->getName(false));
245240

246-
if (null !== $this->reportUselessTests) {
247-
$test->getTestResultObject()->beStrictAboutTestsThatDoNotTestAnything($this->reportUselessTests);
248-
$this->reportUselessTests = null;
249-
}
250-
251241
if ($errored = null !== $this->error) {
252242
$test->getTestResultObject()->addError($test, $this->error, 0);
253243
$this->error = null;

0 commit comments

Comments
 (0)
Please sign in to comment.