Skip to content

Commit 9edd5fb

Browse files
committed
append instead of replacing potentially non-existent named-arguments
1 parent 740987c commit 9edd5fb

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

+9-11
Original file line numberDiff line numberDiff line change
@@ -2594,27 +2594,25 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $
25942594

25952595
if (ContainerBuilder::willBeAvailable('symfony/mercure-notifier', MercureTransportFactory::class, $parentPackages, true) && ContainerBuilder::willBeAvailable('symfony/mercure-bundle', MercureBundle::class, $parentPackages, true) && \in_array(MercureBundle::class, $container->getParameter('kernel.bundles'), true)) {
25962596
$container->getDefinition($classToServices[MercureTransportFactory::class])
2597-
->replaceArgument('$registry', new Reference(HubRegistry::class))
2598-
->replaceArgument('$client', new Reference('http_client', ContainerBuilder::NULL_ON_INVALID_REFERENCE))
2599-
->replaceArgument('$dispatcher', new Reference('event_dispatcher', ContainerBuilder::NULL_ON_INVALID_REFERENCE));
2597+
->replaceArgument('$registry', new Reference(HubRegistry::class));
26002598
} elseif (ContainerBuilder::willBeAvailable('symfony/mercure-notifier', MercureTransportFactory::class, $parentPackages, true)) {
26012599
$container->removeDefinition($classToServices[MercureTransportFactory::class]);
26022600
}
26032601

26042602
if (ContainerBuilder::willBeAvailable('symfony/fake-chat-notifier', FakeChatTransportFactory::class, ['symfony/framework-bundle', 'symfony/notifier', 'symfony/mailer'], true)) {
26052603
$container->getDefinition($classToServices[FakeChatTransportFactory::class])
2606-
->replaceArgument('$mailer', new Reference('mailer'))
2607-
->replaceArgument('$logger', new Reference('logger'))
2608-
->replaceArgument('$client', new Reference('http_client', ContainerBuilder::NULL_ON_INVALID_REFERENCE))
2609-
->replaceArgument('$dispatcher', new Reference('event_dispatcher', ContainerBuilder::NULL_ON_INVALID_REFERENCE));
2604+
->replaceArgument(0, new Reference('mailer'))
2605+
->replaceArgument(1, new Reference('logger'))
2606+
->addArgument(new Reference('event_dispatcher', ContainerBuilder::NULL_ON_INVALID_REFERENCE))
2607+
->addArgument(new Reference('http_client', ContainerBuilder::NULL_ON_INVALID_REFERENCE));
26102608
}
26112609

26122610
if (ContainerBuilder::willBeAvailable('symfony/fake-sms-notifier', FakeSmsTransportFactory::class, ['symfony/framework-bundle', 'symfony/notifier', 'symfony/mailer'], true)) {
26132611
$container->getDefinition($classToServices[FakeSmsTransportFactory::class])
2614-
->replaceArgument('$mailer', new Reference('mailer'))
2615-
->replaceArgument('$logger', new Reference('logger'))
2616-
->replaceArgument('$client', new Reference('http_client', ContainerBuilder::NULL_ON_INVALID_REFERENCE))
2617-
->replaceArgument('$dispatcher', new Reference('event_dispatcher', ContainerBuilder::NULL_ON_INVALID_REFERENCE));
2612+
->replaceArgument(0, new Reference('mailer'))
2613+
->replaceArgument(1, new Reference('logger'))
2614+
->addArgument(new Reference('event_dispatcher', ContainerBuilder::NULL_ON_INVALID_REFERENCE))
2615+
->addArgument(new Reference('http_client', ContainerBuilder::NULL_ON_INVALID_REFERENCE));
26182616
}
26192617

26202618
if (isset($config['admin_recipients'])) {

0 commit comments

Comments
 (0)