Remove BoolishClassMethodPrefixRule as very limited and often ignored (#114)

* Remove BoolishClassMethodPrefixRule as very limited and often ignored

* bump deps

* static fixes

* misc

Author: TomasVotruba

composer.json

@@ -7,16 +7,16 @@
         "php": ">=8.1",
         "nette/utils": "^3.2.9 || ^4.0",
         "webmozart/assert": "^1.11",
-        "phpstan/phpstan": "^1.10.30",
+        "phpstan/phpstan": "^1.11",
         "symplify/rule-doc-generator-contracts": "^11.1.26"
     },
     "require-dev": {
-        "nikic/php-parser": "^4.18",
+        "nikic/php-parser": "^4.19",
         "symplify/phpstan-extensions": "^11.4",
         "symplify/rule-doc-generator": "^12.0",
         "phpunit/phpunit": "^10.5",
         "symfony/framework-bundle": "6.1.*",
-        "rector/rector": "^0.19.0",
+        "rector/rector": "^1.1",
         "symplify/easy-coding-standard": "^12.1",
         "phpstan/extension-installer": "^1.3",
         "tomasvotruba/class-leak": "^0.2"

config/services/services.neon

@@ -12,7 +12,6 @@ services:
     - Symplify\PHPStanRules\Composer\Psr4PathValidator
     - Symplify\PHPStanRules\Formatter\RequiredWithMessageFormatter
     - Symplify\PHPStanRules\Location\DirectoryChecker
-    - Symplify\PHPStanRules\Naming\BoolishNameAnalyser
     - Symplify\PHPStanRules\Naming\ClassToSuffixResolver
     - Symplify\PHPStanRules\NodeAnalyzer\AttributeFinder
     - Symplify\PHPStanRules\NodeAnalyzer\EnumAnalyzer

config/static-rules.neon

@@ -17,7 +17,6 @@ rules:
     - Symplify\PHPStanRules\Rules\NoArrayAccessOnObjectRule
 
     - Symplify\PHPStanRules\Rules\NoNullableArrayPropertyRule
-    - Symplify\PHPStanRules\Rules\BoolishClassMethodPrefixRule
 
     # dead-code
     - Symplify\PHPStanRules\Rules\NoIssetOnObjectRule

docs/rules_overview.md

@@ -1,4 +1,4 @@
-# 48 Rules Overview
+# 46 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -31,40 +31,6 @@ class SomeClass
 
 <br>
 
-## BoolishClassMethodPrefixRule
-
-Method `"%s()"` returns bool type, so the name should start with is/has/was...
-
-- class: [`Symplify\PHPStanRules\Rules\BoolishClassMethodPrefixRule`](../src/Rules/BoolishClassMethodPrefixRule.php)
-
-```php
-class SomeClass
-{
-    public function old(): bool
-    {
-        return $this->age > 100;
-    }
-}
-```
-
-:x:
-
-<br>
-
-```php
-class SomeClass
-{
-    public function isOld(): bool
-    {
-        return $this->age > 100;
-    }
-}
-```
-
-:+1:
-
-<br>
-
 ## CheckClassNamespaceFollowPsr4Rule
 
 Class like namespace "%s" does not follow PSR-4 configuration in `composer.json`
@@ -616,44 +582,6 @@ interface RunnableInterface
 
 <br>
 
-## NoAbstractRule
-
-Instead of abstract class, use specific service with composition
-
-- class: [`Symplify\PHPStanRules\Rules\Complexity\NoAbstractRule`](../src/Rules/Complexity/NoAbstractRule.php)
-
-```php
-final class NormalHelper extends AbstractHelper
-{
-}
-
-abstract class AbstractHelper
-{
-}
-```
-
-:x:
-
-<br>
-
-```php
-final class NormalHelper
-{
-    public function __construct(
-        private SpecificHelper $specificHelper
-    ) {
-    }
-}
-
-final class SpecificHelper
-{
-}
-```
-
-:+1:
-
-<br>
-
 ## NoArrayAccessOnObjectRule
 
 Use explicit methods over array access on object

phpstan.neon

@@ -10,7 +10,7 @@ parameters:
         - config
         - tests
 
-    reportUnmatchedIgnoredErrors: false
+    # reportUnmatchedIgnoredErrors: false
 
     excludePaths:
         # parallel
@@ -52,5 +52,4 @@ parameters:
         - '#Method Symplify\\PHPStanRules\\(.*?)\:\:getRule\(\) return type with generic interface PHPStan\\Rules\\Rule does not specify its types\: TNodeType#'
 
         # part of public contract
-        - '#Public constant "Symplify\\PHPStanRules\\(.*?)\:\:ERROR_MESSAGE" is never used#'
         - '#Method Symplify\\PHPStanRules\\Tests\\Rules\\PHPUnit\\(.*?)\\(.*?)Test\:\:testRule\(\) has parameter \$expectedErrorMessagesWithLines with no value type specified in iterable type array#'

src/Naming/BoolishNameAnalyser.php

@@ -22,6 +22,7 @@
 use Rector\NodeTypeResolver\Node\AttributeKey;
 
 /**
+ * @api used in rector rules
  * @see \Symplify\PHPStanRules\Tests\ReturnTypeExtension\NodeGetAttributeTypeExtension\NodeGetAttributeTypeExtensionTest
  */
 final class NodeGetAttributeTypeExtension implements DynamicMethodReturnTypeExtension

src/ReturnTypeExtension/NodeGetAttributeTypeExtension.php

@@ -15,7 +15,6 @@
 use PHPUnit\Framework\TestCase;
 use Rector\Rector\AbstractRector;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
-use Symfony\Component\Console\Command\Command;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symplify\PHPStanRules\Naming\ClassToSuffixResolver;
 use Symplify\RuleDocGenerator\Contract\ConfigurableRuleInterface;
@@ -37,7 +36,7 @@ final class ClassNameRespectsParentSuffixRule implements Rule, DocumentedRuleInt
      * @var string[]
      */
     private const DEFAULT_PARENT_CLASSES = [
-        Command::class,
+        'Symfony\Component\Console\Command\Command',
         EventSubscriberInterface::class,
         AbstractController::class,
         Sniff::class,
@@ -111,7 +110,7 @@ class SomeCommand extends Command
 CODE_SAMPLE
                 ,
                 [
-                    'parentClasses' => [Command::class],
+                    'parentClasses' => ['Symfony\Component\Console\Command\Command'],
                 ]
             ),
         ]);

src/Rules/BoolishClassMethodPrefixRule.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Symfony\Component\Console\Command;
+
+if (class_exists('Symfony\Component\Console\Command\Command')) {
+    return;
+}
+
+class Command
+{
+}