Skip attributes on setter rule (#120)

* add route test fixture

* add route test fixture

* skip attributed class method

Author: TomasVotruba

src/Rules/NoReturnSetterMethodRule.php

@@ -53,12 +53,12 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
-        $classReflection = $scope->getClassReflection();
-        if (! $classReflection instanceof ClassReflection) {
+        // possibly some important logic
+        if ($node->attrGroups !== []) {
             return [];
         }
 
-        if (! $classReflection->isClass()) {
+        if (! $this->isInsideClassReflection($scope)) {
             return [];
         }
 
@@ -124,4 +124,14 @@ private function hasReturnReturnFunctionLike(ClassMethod $classMethod): bool
         $yield = $this->typeAwareNodeFinder->findFirstInstanceOf($classMethod, Yield_::class);
         return $yield instanceof Yield_;
     }
+
+    private function isInsideClassReflection(Scope $scope): bool
+    {
+        $classReflection = $scope->getClassReflection();
+        if (! $classReflection instanceof ClassReflection) {
+            return false;
+        }
+
+        return $classReflection->isClass();
+    }
 }

tests/Rules/NoReturnSetterMethodRule/Fixture/SkipRoute.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\NoReturnSetterMethodRule\Fixture;
+
+use Symfony\Component\HttpFoundation\JsonResponse;
+use Symfony\Component\Routing\Attribute\Route;
+
+final class SkipRoute
+{
+    #[Route('some_route')]
+    public function setIncome(string $name): JsonResponse
+    {
+        return new JsonResponse();
+    }
+}

tests/Rules/NoReturnSetterMethodRule/NoReturnSetterMethodRuleTest.php

@@ -25,6 +25,7 @@ public static function provideData(): Iterator
     {
         yield [__DIR__ . '/Fixture/SomeSetterClass.php', [[NoReturnSetterMethodRule::ERROR_MESSAGE, 9]]];
 
+        yield [__DIR__ . '/Fixture/SkipRoute.php', []];
         yield [__DIR__ . '/Fixture/SkipEmptyReturn.php', []];
         yield [__DIR__ . '/Fixture/SkipVoidSetter.php', []];
         yield [__DIR__ . '/Fixture/SkipSetUp.php', []];