Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart item width should reflect minutes (was: "To time off by one cell visually when minutes are small like 00") #47

Open
bculley opened this issue Oct 25, 2012 · 3 comments
Labels
Milestone

Comments

@bculley
Copy link

bculley commented Oct 25, 2012

My app has 15 minute intervals, each hour at 00, 15, 30 and 45 minutes.

In the hours view, creating a time from 0000 to 2200 realizes a bar that extends into the "22" cell, but since the minutes are "00" on the "2200", it would make more sense to stop it in the "21" cell, since the "21" cell is already 100% full. This would not be an issue if it could divide the cell into 60 parts for minutes. Currently my workaround is to override the display value to subtract 1 minute on the stop times and adjust to the previous hour, except where hour = 00;

@usmonster
Copy link
Collaborator

@bculley, can you check if this is still an issue in the current plugin version in master, as it may have been fixed by ebf84ca. If it's fixed the issue can be closed. Thanks for reporting it!

@usmonster
Copy link
Collaborator

I just checked, and it's indeed still an issue, as demonstrated in this fiddle: http://jsfiddle.net/Zat2U/4/ .

The second item is one hour long and, as such, should not appear as a 2-hour-long item. This appears to be an issue in the display code, and would also affect other scales when there are items that end on certain time unit boundaries.

@usmonster usmonster added this to the v1.2.0 milestone Dec 24, 2014
@usmonster usmonster changed the title To time off by one cell visually when minutes are small like 00 Chart item width should reflect minutes (was: "To time off by one cell visually when minutes are small like 00") Feb 27, 2019
@usmonster usmonster mentioned this issue Nov 3, 2019
@0x6D70
Copy link

0x6D70 commented Jul 14, 2021

@usmonster @taitems
Is there any progress here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants