Skip to content

Commit 400edfa

Browse files
richardlautargos
authored andcommitted
deps: V8: cherry-pick f6bef09b3b0a
Original commit message: [turboshaft] initialize constant_value_ to an empty value gcc-10 seems to have a bug were not initializing this value throws this compilation error: ``` src/compiler/turboshaft/assembler.h:680:16: error: ‘<anonymous>’ is used uninitialized in this function [-Werror=uninitialized] 680 | return Get(); ``` https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86465 Bug: v8:12783 Change-Id: I7a5fee5009b866a801326fba734c156c3cfdb1b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5503350 Reviewed-by: Nico Hartmann <[email protected]> Commit-Queue: Milad Farazmand <[email protected]> Cr-Commit-Position: refs/heads/main@{#93675} Refs: v8/v8@f6bef09 PR-URL: nodejs#52802 Fixes: nodejs#52661 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
1 parent 109f93e commit 400edfa

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.7',
39+
'v8_embedder_string': '-node.8',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/compiler/turboshaft/index.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -671,7 +671,7 @@ class ConstOrV {
671671
template <typename U,
672672
typename = std::enable_if_t<std::is_constructible_v<V<T>, V<U>>>>
673673
ConstOrV(V<U> index) // NOLINT(runtime/explicit)
674-
: constant_value_(), value_(index) {}
674+
: constant_value_(std::nullopt), value_(index) {}
675675

676676
bool is_constant() const { return constant_value_.has_value(); }
677677
constant_type constant_value() const {

0 commit comments

Comments
 (0)