Skip to content

Commit b7c7b20

Browse files
committed
deps: V8: cherry-pick 9a6a22874c81
Original commit message: [heap] Fix DCHECK in TransitionArrayNeedsCompaction The dead target check in TransitionArrayNeedsCompaction, confirming that Smi (uninitialized) targets imply that no other target is dead, has to additionally support Smi entries. Bug: v8:11305 Change-Id: I6f3fa9e7420b1bd0a64a25dae670f439e3f41162 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622914 Commit-Queue: Leszek Swirski <[email protected]> Commit-Queue: Ulan Degenbaev <[email protected]> Auto-Submit: Leszek Swirski <[email protected]> Reviewed-by: Ulan Degenbaev <[email protected]> Cr-Commit-Position: refs/heads/master@{#72040} Refs: v8/v8@9a6a228 PR-URL: nodejs#36139 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
1 parent e69a549 commit b7c7b20

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.9',
39+
'v8_embedder_string': '-node.10',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/heap/mark-compact.cc

+3-1
Original file line numberDiff line numberDiff line change
@@ -2290,7 +2290,9 @@ bool MarkCompactCollector::TransitionArrayNeedsCompaction(
22902290
#ifdef DEBUG
22912291
// Targets can only be dead iff this array is fully deserialized.
22922292
for (int i = 0; i < num_transitions; ++i) {
2293-
DCHECK(!non_atomic_marking_state()->IsWhite(transitions.GetTarget(i)));
2293+
DCHECK_IMPLIES(
2294+
!transitions.GetRawTarget(i).IsSmi(),
2295+
!non_atomic_marking_state()->IsWhite(transitions.GetTarget(i)));
22942296
}
22952297
#endif
22962298
return false;

0 commit comments

Comments
 (0)