Skip to content

Focal loss migration #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AakashKumarNain opened this issue Jul 15, 2020 · 4 comments
Closed

Focal loss migration #2004

AakashKumarNain opened this issue Jul 15, 2020 · 4 comments

Comments

@AakashKumarNain
Copy link
Member

@tanzhenyu moving the discussion regarding focal loss from #914 to here. Here is a working colab for the cases you asked.

https://colab.research.google.com/drive/1JIaUVOHC0rTsBWKK-oTBv5qZJ5zLJzTQ?usp=sharing

@bhack
Copy link
Contributor

bhack commented Sep 19, 2020

@tanzhenyu
Copy link
Contributor

Thanks @AakashKumarNain . I don't have access to the colab. We do provided a keras_cv focal loss. Let us know if the implementation serves your need.

@AakashKumarNain
Copy link
Member Author

Thanks @tanzhenyu . The implementation is good but I have one concern. This loss should be included in core keras because:

  1. It is not limited to object detection or computer vision only. Anything that involves cross-entropy loss can leverage focal loss as well. Including it in a cv specific package sends a message that it works only for CV which isn't true.
  2. Focal loss was introduced in 2017. It has enough citations to be included in the core.

Let me know what you think

@seanpmorgan
Copy link
Member

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down

Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants