Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distort_image_ops_test.py fails on tf-nightly-2.0-gpu #373

Closed
WindQAQ opened this issue Jul 26, 2019 · 3 comments · Fixed by #395
Closed

distort_image_ops_test.py fails on tf-nightly-2.0-gpu #373

WindQAQ opened this issue Jul 26, 2019 · 3 comments · Fixed by #395
Labels
bug Something isn't working image

Comments

@WindQAQ
Copy link
Member

WindQAQ commented Jul 26, 2019

The CI Build for PY2-GPU failed because of distort_image_ops_test.py.
https://source.cloud.google.com/results/invocations/7ed10b8d-6cba-47d9-b764-d823365528f4/log

Ideally, the manager should catch the exception raised in CC file

with self.assertRaisesOpError("input must have 3 channels "
"but instead has 4 channels"):
self.evaluate(self._adjust_hue_in_yiq_tf(x_np, delta_h))

OP_REQUIRES(
context, channels == kChannelSize,
errors::InvalidArgument("input must have 3 channels but instead has ",
channels, " channels."));

@seanpmorgan
Copy link
Member

seanpmorgan commented Jul 29, 2019

So more info:
Seems not related to py2 vs py3. There has not been a gpu-py34 released since 20190718 so that's why it's passing.

The error is incredibly cryptic when decorated with tf.function... and when I remove that it looks like 2 errors are being raised instead of the one we're catching:

InvalidArgumentError: input must be at least 3-D, got shape[2,3] [Op:AdjustHsvInYiq]

and

ValueError: Shape must be at least rank 3 but is rank 2 for 'adjust_hsv_in_yiq/AdjustHsvInYiq' (op: 'AdjustHsvInYiq') with input shapes: [2,3], [], [], [].

I have no idea which commit started this and no reason why it's only happening on the GPU pip package.

@seanpmorgan seanpmorgan mentioned this issue Jul 29, 2019
7 tasks
@feihugis
Copy link
Member

It can run in the eager mode but failed in the graph mode. I tried to add the GPU kernel but the build failed. Will update it here if I get any progress.

@seanpmorgan seanpmorgan changed the title [BUG] distort_image_ops_test.py fails in PY2-GPU [BUG] distort_image_ops_test.py fails on tf-nightly-2.0-gpu Jul 30, 2019
@seanpmorgan seanpmorgan changed the title [BUG] distort_image_ops_test.py fails on tf-nightly-2.0-gpu distort_image_ops_test.py fails on tf-nightly-2.0-gpu Jul 31, 2019
@seanpmorgan
Copy link
Member

For tracking purposes... a temporary fix was put in #378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working image
Projects
None yet
3 participants