You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
In #4399, we decided to recommend `..Default::default()` on struct
initializers for protos whose source of truth is not in our repo. This
patch removes trivial `..Default::default()`s from struct initializers
for `tensorboard.data` protos, which *do* live in our repo. We still use
it sometimes: e.g., some requests have a `run_tag_filter` field that we
don’t always care to set.
This patch will make it harder to add new fields to these protos, but
makes the code a bit easier to read in the meantime.
Test Plan:
Compilation suffices; unit tests are a nice sanity check.
wchargin-branch: rust-remove-default-frus
wchargin-source: 8b007d8f650840dbf05c459a3414d9dd421170a8
0 commit comments