[Bug]: Suspected fish update to 4.0.0 has a character display bug

[dilongx]

Problem description

When fish is updated to 4.0.0, "5u" is displayed in the command prompt.

What steps will reproduce the bug?

Update fish to 4.0.0

What is the expected behavior?

No response

System information

Termux Variables:
TERMUX_API_VERSION=0.50.1
TERMUX_APK_RELEASE=F_DROID
TERMUX_APP_PACKAGE_MANAGER=pacman
TERMUX_APP_PID=4816
TERMUX_IS_DEBUGGABLE_BUILD=0
TERMUX_MAIN_PACKAGE_FORMAT=pacman
TERMUX_VERSION=0.118.1
TERMUX__USER_ID=0
Packages CPU architecture:
aarch64
Subscribed repositories:
# /data/data/com.termux/files/usr/etc/pacman.conf
[main]
Usage = All
Server = https://service.termux-pacman.dev/main/aarch64
Server = https://s3.amazonaws.com/termux-pacman.us/main/aarch64
[x11]
Usage = All
Server = https://service.termux-pacman.dev/x11/aarch64
Server = https://s3.amazonaws.com/termux-pacman.us/x11/aarch64
[root]
Usage = All
Server = https://service.termux-pacman.dev/root/aarch64
Server = https://s3.amazonaws.com/termux-pacman.us/root/aarch64
[tur]
Usage = All
Server = https://service.termux-pacman.dev/tur/aarch64
Server = https://s3.amazonaws.com/termux-pacman.us/tur/aarch64
[tur-continuous]
Usage = All
Server = https://service.termux-pacman.dev/tur-continuous/aarch64
Server = https://s3.amazonaws.com/termux-pacman.us/tur-continuous/aarch64
[tur-multilib]
Usage = All
Server = https://service.termux-pacman.dev/tur-multilib/aarch64
Server = https://s3.amazonaws.com/termux-pacman.us/tur-multilib/aarch64
[gpkg]
Usage = All
Server = https://service.termux-pacman.dev/gpkg/aarch64
Server = https://s3.amazonaws.com/termux-pacman.us/gpkg/aarch64
Updatable packages:
command-not-found 2.4.0-65 -> 2.4.0-66
termux-tools version:
1.44.6
Android version:
13
Kernel build information:
Linux localhost 5.10.218-android12-9-g5767b19bed0c-dirty #1 SMP PREEMPT Tue Feb 11 06:38:07 UTC 2025 aarch64 Android
Device manufacturer:
vivo
Device model:
V2279A
LD Variables:
LD_LIBRARY_PATH=
LD_PRELOAD=/data/data/com.termux/files/usr/lib/libtermux-exec.so
Installed termux plugins:
com.termux.api versionCode:51

[TomJo2000]

That's a known issue.
We'll be shipping a temporary workaround shortly.

[EnderNon]

The issue still persists in proot (tested on archlinux). Since I assume the archlinux proot is using archlinux-arm, do I contact the archlinux-arm packagers?

[TomJo2000]

This is a bug, or more accurately missing feature, in Termux.
As a temporary workaround we are disabling the kitty keyboard protocol in our default fish config.

This is not a bug with fish.

termux-packages/packages/fish/build.sh

Lines 54 to 61 in 5a00faa

	cat >> "$TERMUX_PREFIX/etc/fish/config.fish" <<-EOF
	function __fish_command_not_found_handler --on-event fish_command_not_found
	$TERMUX_PREFIX/libexec/termux/command-not-found \$argv[1]
	end
	# TODO: remove when https://github.com/termux/termux-app/pull/4417 gets released
	status test-feature keyboard-protocols && set -U fish_features no-keyboard-protocols
	EOF

[dilongx]

This is a bug, or more accurately missing feature, in Termux.
As a temporary workaround we are disabling the kitty keyboard protocol in our default fish config.

This is not a bug with fish.

termux-packages/packages/fish/build.sh

Lines 54 to 61 in 5a00faa

	cat >> "$TERMUX_PREFIX/etc/fish/config.fish" <<-EOF
	function __fish_command_not_found_handler --on-event fish_command_not_found
	$TERMUX_PREFIX/libexec/termux/command-not-found \$argv[1]
	end
	# TODO: remove when https://github.com/termux/termux-app/pull/4417 gets released
	status test-feature keyboard-protocols && set -U fish_features no-keyboard-protocols
	EOF

I see that Termux has merged the PR for fixing the problem.
When will Termux release the next version to fix this?

[TomJo2000]

• We merged fix(main/fish): disable keyboard protocols that print extra characters #23686 in this repository which deals with the packages available on Termux.
  There is a separate PR on the main app repository that would fix this (and a related issue with colorized underlines) by fully consuming unimplemented escape sequences.
  Fixed: fully consume unknown CSI sequences containing non-numeric parameter byte termux-app#4417
  Once that is merged and released the issue will be "fixed".
  Though that PR does not implement support for the Kitty keyboard protocol.