Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Staging Distributon #131

Closed
ogugu9 opened this issue Feb 21, 2024 · 3 comments · Fixed by #130
Closed

Support for Staging Distributon #131

ogugu9 opened this issue Feb 21, 2024 · 3 comments · Fixed by #130

Comments

@ogugu9
Copy link
Contributor

ogugu9 commented Feb 21, 2024

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

  • Yes ✅: please list the AWS provider version which introduced this functionality

CHANGELOG: https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#5120-august-10-2023

New Resource: aws_cloudfront_continuous_deployment_policy (hashicorp/terraform-provider-aws#32936)

Is your request related to a problem? Please describe.

In order to use staging distribution, we must set staging = true to the staging distribution and specify continuous_deployment_policy_id for the primary distribution.
However, this module doesn't support these variables.

Describe the solution you'd like.

  • Add staging variable.
  • Add continuous_deployment_policy_id variable.

I created PR: #130

Describe alternatives you've considered.

  • Give up on using this module and use AWS Provider directly.

Additional context

@ogugu9
Copy link
Contributor Author

ogugu9 commented Feb 22, 2024

@antonbabenko @bryantbiggs
I'm sorry, could you check this issue and corresponding PR #130 ...?

@antonbabenko
Copy link
Member

This issue has been resolved in version 3.3.0 🎉

Copy link

github-actions bot commented Apr 1, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants