Skip to content

Commit ca7593a

Browse files
author
Paul Pop
authored
fix: The type of the output cloudwatch_log_group_name should be a string instead of a list of strings (#1061)
NOTES: The output `cloudwatch_log_group_name` was incorrectly returning the log group name as a list of strings. As a workaround, people were using `module.eks_cluster.cloudwatch_log_group_name[0]` but that was totally inconsistent with output name. Those users can now use `module.eks_cluster.cloudwatch_log_group_name` directly.
1 parent 751c422 commit ca7593a

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ MIT Licensed. See [LICENSE](https://github.com/terraform-aws-modules/terraform-a
202202
| map\_roles | Additional IAM roles to add to the aws-auth configmap. See examples/basic/variables.tf for example format. | <pre>list(object({<br> rolearn = string<br> username = string<br> groups = list(string)<br> }))</pre> | `[]` | no |
203203
| map\_users | Additional IAM users to add to the aws-auth configmap. See examples/basic/variables.tf for example format. | <pre>list(object({<br> userarn = string<br> username = string<br> groups = list(string)<br> }))</pre> | `[]` | no |
204204
| node\_groups | Map of map of node groups to create. See `node_groups` module's documentation for more details | `any` | `{}` | no |
205-
| node\_groups\_defaults | Map of values to be applied to all node groups. See `node_groups` module's documentaton for more details | `any` | `{}` | no |
205+
| node\_groups\_defaults | Map of values to be applied to all node groups. See `node_groups` module's documentation for more details | `any` | `{}` | no |
206206
| permissions\_boundary | If provided, all IAM roles will be created with this permissions boundary attached. | `string` | `null` | no |
207207
| subnets | A list of subnets to place the EKS cluster and workers within. | `list(string)` | n/a | yes |
208208
| tags | A map of tags to add to all resources. | `map(string)` | `{}` | no |

outputs.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ output "cluster_primary_security_group_id" {
5858

5959
output "cloudwatch_log_group_name" {
6060
description = "Name of cloudwatch log group created"
61-
value = aws_cloudwatch_log_group.this[*].name
61+
value = element(concat(aws_cloudwatch_log_group.this[*].name, list("")), 0)
6262
}
6363

6464
output "kubeconfig" {

variables.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ variable "create_eks" {
318318
}
319319

320320
variable "node_groups_defaults" {
321-
description = "Map of values to be applied to all node groups. See `node_groups` module's documentaton for more details"
321+
description = "Map of values to be applied to all node groups. See `node_groups` module's documentation for more details"
322322
type = any
323323
default = {}
324324
}

0 commit comments

Comments
 (0)