Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for security groups for pods #1021

Closed
1 of 4 tasks
stpierre opened this issue Sep 24, 2020 · 5 comments
Closed
1 of 4 tasks

Support for security groups for pods #1021

stpierre opened this issue Sep 24, 2020 · 5 comments

Comments

@stpierre
Copy link

I have issues

I'm submitting a...

  • bug report
  • feature request
  • support request - read the FAQ first!
  • kudos, thank you, warm fuzzy

What is the current behavior?

Security groups for pods must be provisioned separately from this module.

TBH I'm not even sure how to do this with Terraform, which is why this is a feature request and not a PR. The main sticking point is step 3:

kubectl set env daemonset aws-node -n kube-system ENABLE_POD_ENI=true

I.e., you have to modify the environment for an already-running DaemonSet that is not managed by Terraform, but is created automatically by AWS.

@max-rocket-internet
Copy link
Contributor

This is way out of the scope of this module. You can read about why in #635 🙂

@stpierre
Copy link
Author

Fair enough. Any thoughts about how this could be supported (i.e., in one of those smaller, composable modules discussed in #635)? Is local_exec (sadly) the way to go here?

@max-rocket-internet
Copy link
Contributor

I don't think it's too complicated...

Is local_exec (sadly) the way to go here?

I don't think local_exec is ever the way to go 😅

I think most people are using Helm to manage resources inside the cluster, so looking at the AWS docs, this is how I would do it:

  1. Do it in the aws-vpc-cni chart
  2. Do it in TF, attach the policy to module.cluster_iam_role_arn
  3. Do it in the aws-vpc-cni chart
  4. In your application chart (or elsewhere)
  5. In your application chart, add the SecurityGroupPolicy to the chart
  6. This is just installing the chart

@stpierre
Copy link
Author

stpierre commented Oct 1, 2020

Thanks!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants