Prevent creation of windows ami datasource when we don't define windows worker nodes

[ootkin]

I have issues

I'm submitting a...

• bug report
• feature request
• support request - read the FAQ first!
• kudos, thank you, warm fuzzy

What is the current behavior?

I've just created an EKS cluster and I saw that the module is creating eks_worker_windows automatically.

Is there a way to prevent eks_worker_windows creation? I would like to keep my state as clean as possible.

Thanks.

[barryib]

Humm... Sounds wired. The module create linux boxes by default.

It creates windows boxes only when platform=windows.

Please share your code, module version, terraform versions and plan output.

[barryib]

You're just getting the windows ami (ami data source). It doesn't do anything. As you can notice in your plan, there are no windows nodes.

[ootkin]

Yes, i know but it's quite useless to keep it in the state if i don't use it. Is there a way to remove it?

[barryib]

We can't right now. I don't think, this make any harm, But I'll happy to review a PR for that.

[ootkin]

Thanks @barryib

[bilalbayasut]

have same problem, is this resolved yet ?

[hamishforbes]

The windows AMI lookup is currently breaking upgrading clusters to v1.19 as there isnt a v1.19 windows AMI available yet (at least not in my regions).
Bit annoying to troubleshoot because TF just exits with an error "Your query returned no results." and doesn't actually tell you which resource caused the problem 🙄

Workaround is to change the worker_ami_name_filter_windows variable.

[barryib]

I just opened #1371 to address this. Will you please review it and test it ?

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.