-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for different subnets in fargate profile configurations #1126
Comments
Running into same issue. Created clusters with both private and public subnets, although the worker groups are restricted to private subnets. Can't really remember the reason. Maybe it was the initial requirement of managed nodes to be in public subnets, maybe I goofed up. |
The problem seems to be that fargate only supports private subnets but the module attaches all subnets with no regard to private public (thus attaching public) here |
@myoung34 actually the patch provided gives you the ability to pass any subnet to the fargate profile. If you don't pass a specific subnet it's going to use the var.subnets. In that case yes, if var.subnets contains public subnet it may be a problem (did not verify it) but is not really related with this patch, it keeps the same default behaviour as before. I can actually close this since the patch has been merged. |
That's part of the problem @aittam there's only one This makes it so that you cant have a public control plane and private fargate workers, no? |
Ah, looks like the patch fixed the issue I had. I'll try again when I get back to this one |
closing since we now have subnets argument for fargate profile. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
I have issues
I want to create an eks cluster with both fargate and node group support. I also want to have many fargate profiles with different subnet configurations.
I'm submitting a...
What is the current behavior?
The current behavior is that all fargate profiles shares the same private subnets as the EKS cluster. Specifically the ones passed by the variable subnets.
What's the expected behavior?
The expected behavior is to be able to customize the fargate profiles subnets input variable for each profile
Are you able to fix this problem and submit a PR? Link here if you have already.
I have already contributed to a fix, this is the PR link.
Environment details
Any other relevant info
The text was updated successfully, but these errors were encountered: