Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags on Fargate profiles aren't created properly #1156

Closed
1 of 4 tasks
Lena-nfb opened this issue Dec 21, 2020 · 2 comments
Closed
1 of 4 tasks

Tags on Fargate profiles aren't created properly #1156

Lena-nfb opened this issue Dec 21, 2020 · 2 comments

Comments

@Lena-nfb
Copy link
Contributor

Lena-nfb commented Dec 21, 2020

I have issues

with tags on fargate profiles

I'm submitting a...

  • bug report
  • feature request
  • support request - read the FAQ first!
  • kudos, thank you, warm fuzzy

What is the current behavior?

when create an EKS cluster on fargate tags aren't created properly on fargate profiles. When tags object exists on fargate profile as in the example then the tags aren't merged with the tags from the cluster but swallowed.

If this is a bug, how to reproduce? Please include a code sample if relevant.

If you terraform plan the fargate example it should output

 # module.eks.module.fargate.aws_eks_fargate_profile.this["example"] will be created
  + resource "aws_eks_fargate_profile" "this" {
      + arn                    = (known after apply)
      + cluster_name           = (known after apply)
      + fargate_profile_name   = (known after apply)
      + id                     = (known after apply)
      + pod_execution_role_arn = (known after apply)
      + status                 = (known after apply)
      + subnet_ids             = (known after apply)
      + tags                   = {
          + "Owner" = "test"
        }

      + selector {
          + namespace = "default"
        }
    }

What's the expected behavior?

It should output

  # module.eks.module.fargate.aws_eks_fargate_profile.this["example"] will be created
  + resource "aws_eks_fargate_profile" "this" {
      + arn                    = (known after apply)
      + cluster_name           = (known after apply)
      + fargate_profile_name   = (known after apply)
      + id                     = (known after apply)
      + pod_execution_role_arn = (known after apply)
      + status                 = (known after apply)
      + subnet_ids             = (known after apply)
      + tags                   = {
          + "Environment" = "test"
          + "GithubOrg"   = "terraform-aws-modules"
          + "GithubRepo"  = "terraform-aws-eks"
          + "Owner"       = "test"
        }

      + selector {
          + namespace = "default"
        }
    }

Are you able to fix this problem and submit a PR? Link here if you have already.

PR-1159

@barryib
Copy link
Member

barryib commented Dec 23, 2020

closing since #1159 is now merged.

@barryib barryib closed this as completed Dec 23, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants