Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nitro enclaves in launch template #1181

Closed
3 tasks
yoavj1 opened this issue Jan 10, 2021 · 1 comment · Fixed by #1185
Closed
3 tasks

Support nitro enclaves in launch template #1181

yoavj1 opened this issue Jan 10, 2021 · 1 comment · Fixed by #1185

Comments

@yoavj1
Copy link

yoavj1 commented Jan 10, 2021

I have issues

Please support AWS nitro enclaves in workers_launch_template

I'm submitting a...

  • bug report
  • [V] feature request
  • support request - read the FAQ first!
  • kudos, thank you, warm fuzzy

What is the current behavior?

enclave_options is not set in workers_launch_template

If this is a bug, how to reproduce? Please include a code sample if relevant.

What's the expected behavior?

Expose enclave_support option in worker_launch_template

Are you able to fix this problem and submit a PR? Link here if you have already.

Yes, the change should be pretty simple. A fix in a fork I have looks like this:
diff --git a/local.tf b/local.tf
index a07aec8..c998b24 100644
--- a/local.tf
+++ b/local.tf
@@ -54,6 +54,7 @@ locals {
additional_userdata = "" # userdata to append to the default userdata.
ebs_optimized = true # sets whether to use ebs optimization on supported types.
enable_monitoring = true # Enables/disables detailed monitoring.
+ enclave_support = false # Enables/disables enclave support
public_ip = false # Associate a public ip address with a worker
kubelet_extra_args = "" # This string is passed directly to kubelet if set. Useful for adding labels or taints.
subnets = var.subnets # A list of subnets to place the worker nodes in. i.e. ["subnet-123", "subnet-456", "subnet-789"]
diff --git a/workers_launch_template.tf b/workers_launch_template.tf
index d7c4b41..f574fcc 100644
--- a/workers_launch_template.tf
+++ b/workers_launch_template.tf
@@ -272,6 +272,14 @@ resource "aws_launch_template" "workers_launch_template" {
)[count.index]
}

+ enclave_options {
+ enabled = lookup(
+ var.worker_groups_launch_template[count.index],
+ "enclave_support",
+ local.workers_group_defaults["enclave_support"],
+ )
+ }
+

Environment details

  • Affected module version: relevant for aws version >= 3.22.0, which is the version enclave support was added
  • OS: N/A
  • Terraform version: N/A

Any other relevant info

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant