"root_volume_size" has no effect on self-managed Windows node groups

[yafanasiev]

I have issues

Root EBS volume of self-managed Windows node groups does not change when setting "root_volume_size".

I'm submitting a...

• bug report
• feature request
• support request - read the FAQ first!
• kudos, thank you, warm fuzzy

What is the current behavior?

When adding a "root_volume_size" to node group configuration, a new EBS volume is attached to EC2 instance alongside with root volume.

If this is a bug, how to reproduce? Please include a code sample if relevant.

{
      name                          = "windows-nodes"
      platform                      = "windows"
      asg_max_size                  = "4"
      asg_desired_capacity          = "4"
      asg_min_size                  = "2"
      subnets                       = REDACTED
      additional_security_group_ids = [REDACTED]
      key_name                      = "REDACTED"
      instance_type                 = "t3a.large"
      cpu_credits                   = "unlimited"
      protect_from_scale_in         = true
      kubelet_extra_args            = "--register-with-taints=\"os=windows:NoSchedule\""
      root_volume_size              = "150"
}

What's the expected behavior?

Modifying this parameter should change the root volume size instead.

Environment details

• Affected module version: 12.0.0
• OS: MacOS Big Sur
• Terraform version: v0.14.4

Any other relevant info

The EBS volume is mounted under /dev/xvda, like in Linux EKS AMI's, instead of /dev/sda1 like it should. Changing configuration to

      ...
      root_volume_size              = "150"
      root_block_device_name        = "/dev/sda1"

fixes the issue. I believe the problem is in

terraform-aws-eks/workers_launch_template.tf

Line 368 in 65777d0

local.workers_group_defaults["root_block_device_name"],

This always gets a root_block_device_name from Linux AMI, as specified in

terraform-aws-eks/local.tf

Line 74 in 65777d0

root_block_device_name = data.aws_ami.eks_worker.root_device_name # Root device name for workers. If non is provided, will assume default AMI was used.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[barryib]

@yafanasiev is #1401 solves your issue ?

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.