Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata options block not supported in node_groups #1353

Closed
primeroz opened this issue May 14, 2021 · 4 comments
Closed

metadata options block not supported in node_groups #1353

primeroz opened this issue May 14, 2021 · 4 comments

Comments

@primeroz
Copy link

primeroz commented May 14, 2021

Is your request related to a problem? Please describe.

The metadata options block is only supported in the workers but not in the node_groups #1301

my understanding is that we could use this options to block access to metadata endpoint from workloads and force the use of IRSA as explained here

Is this on purpose ?

I use node_groups to get managed_groups and i would rather not have to switch to un-managed worker groups.

Describe the solution you'd like.

Support metadata options on the node_group

Describe alternatives you've considered.

Calico policy - they work.

Additional context

I am willing to do a PR but first wanted to check if there is any reason why this was not implemnted in the same PR as the worker_groups one

@barryib
Copy link
Member

barryib commented May 28, 2021

We forgot that MNG now support LT. So please open a PR. I'll happy to review it.

@jmorgan415
Copy link

jmorgan415 commented Jun 11, 2021

We forgot that MNG now support LT. So please open a PR. I'll happy to review it.

I've created a branch locally for this and will submit a PR since this is a pressing issue or us and I haven't seen a PR from the author.

@antonbabenko
Copy link
Member

Fixed in #1485

Please use module v17.18.0.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants