Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to volumes from worker_groups_launch_template["tags"] #1396

Closed
lisfo4ka opened this issue May 26, 2021 · 3 comments · Fixed by #1397
Closed

Add tags to volumes from worker_groups_launch_template["tags"] #1396

lisfo4ka opened this issue May 26, 2021 · 3 comments · Fixed by #1397
Assignees

Comments

@lisfo4ka
Copy link
Contributor

Is your request related to a new offering from AWS?

No

Is your request related to a problem? Please describe.

Our team would like to use EKS cluster as a Production cluster shared for different customers. At the moment, we've already used worker_groups_launch_template["tags"] to mark nodes with custom tags and isolate applications deployment for the customers. But it's required to tag root volumes with custom tags as well since it's important for billing management.

Describe the solution you'd like.

There is already an option to add custom tags for worker_groups_launch_template groups by propagate_at_launch" = "true" option in ASG tags, but there isn't for volumes.

I'd like to get tags on the EC2 volumes if I define worker_groups_launch_template["tags"]

  worker_groups_launch_template = [
    {
      name                    = "spot"
...
      tags = [
        {
          "key"                 = "customer:tag"
          "propagate_at_launch" = "true"
          "value"               = "customerABC"
        },
      ]
    },
  ]

I propose to do that via tag_specifications for volume resource_type in "aws_launch_template" "workers_launch_template" by merging worker_groups_launch_template["tags"] with "Name" = "" and var.tags maps.

@stale
Copy link

stale bot commented Aug 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 26, 2021
@lisfo4ka
Copy link
Contributor Author

@barryib @antonbabenko folks, please, let's give this improvement a second chance. Our team really needs this for the EKS module production usage. I'm open to any suggestions to implement in this change #1397.

@stale stale bot removed the stale label Aug 30, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants