Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has the support for this module gone stale? What can we do? #1520

Closed
NeckBeardPrince opened this issue Aug 9, 2021 · 11 comments
Closed

Has the support for this module gone stale? What can we do? #1520

NeckBeardPrince opened this issue Aug 9, 2021 · 11 comments

Comments

@NeckBeardPrince
Copy link

No commits to master in two months, as of today. Numerous issues on the examples/ failing to work and documentation that is incorrect or very out-of-date. The community has submitted several PRs that end up going unreviewed and no attention given. Several which resolve relatively big issues and annoying issues #1447 and #1446. What can the community do to help get this module back on its feet?

@Chili-Man
Copy link
Contributor

@barryib @bryantbiggs @brandonjbjelland @antonbabenko we need to add more maintainers to these repositories. I don't think it's sustainable for only you guys to be able to maintain all of the terraform aws module repos. I'd be more then happy to help in that area if there was a path forward to do so

@bryantbiggs
Copy link
Member

hey all - apologies for the delays. we have been adding maintainers and that is a route we can explore. the biggest source of time is testing and validating changes, and also validating against breaking changes - for this, anyone can help pitch in and provide feedback on whether or not a change introduces regressions or breakages. let me chat with the group and get back to you shortly - thank you again for your patience

@antonbabenko
Copy link
Member

As Bryant just said, we mostly need help with answering issues and reviewing PRs across all terraform-aws-modules repositories.

Additionally, it is summertime and some of us took or still taking time off.

@NeckBeardPrince
Copy link
Author

As Bryant just said, we mostly need help with answering issues and reviewing PRs across all terraform-aws-modules repositories.

Additionally, it is summertime and some of us took or still taking time off.

I was unaware that it was just four of you maintaining all the AWS modules. That seems like a low number of maintainers for such a large number of highly used modules.

@bryantbiggs
Copy link
Member

we try our best 😅

@daroga0002
Copy link
Contributor

sorry Guys, but I don`t agree that this is just a summer time. I highlighted this issue in #1242 since which nothing changed (there was just few PRs merged and again repo become stale).

From my side, I tried to help with PRs review. Reviewed and tested a few PRs leaving comments, but finally, they become stale for a long time. Now again, they require rework from creators and retesting what again consumes a lot of time.

I don`t want you Guys to criticize, but a lot of the community expects that their work will not be ignored or wasted.

I think the only olutions to solve an issue are:

  • repository is that we need more maintainers who will be able to properly maintain it (preferred)
    or
  • community will need to fork this repo to continue work on it.

@NeckBeardPrince
Copy link
Author

sorry Guys, but I don`t agree that this is just a summer time. I highlighted this issue in #1242 since which nothing changed (there was just few PRs merged and again repo become stale).

From my side, I tried to help with PRs review. Reviewed and tested a few PRs leaving comments, but finally, they become stale for a long time. Now again, they require rework from creators and retesting what again consumes a lot of time.

I don`t want you Guys to criticize, but a lot of the community expects that their work will not be ignored or wasted.

I think the only olutions to solve an issue are:

* repository is that we need more maintainers  who will be able to properly maintain it (preferred)
  or

* community will need to fork this repo to continue work on it.

I in no way want to make any of what I'm about to say sound ungrateful or rude. But the response of "Additionally, it is summertime and some of us took or still taking time off." made by @antonbabenko only goes to show that these NEEDS to be more maintainers in this repo. You guys might be on summer break, but that doesn't mean every company and every team that uses and requires these repos stops working while you're on holiday. This isn't a small set of modules for a small provider here, so when something is broken, it can hinder a team. If you're going on holiday, why not have additional maintainers to help pick up the workload?

@daroga0002
Copy link
Contributor

@antonbabenko
Copy link
Member

@daroga0002 @NeckBeardPrince @Chili-Man We are well aware of the situation in this repository and we are going to discuss it on the 24th of August during Terraform AWS module office hours. Everyone is welcome to join. The rough agenda is in the description on that page.

@antonbabenko
Copy link
Member

#1447 has been fixed and v17.3.0 has been just released.


If anyone wants to hear the discussion we've had about upcoming improvements - see this. There are timestamps in the description to jump through the video.

As stated earlier, we do our best to maintain all terraform-aws-modules. If there are questions, feel free to reach out to me in any way you prefer and we discuss them.

I am closing this issue.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants