Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throughput & iops options for managed node_groups when create_launch_template=true #1567

Closed
etsuo opened this issue Sep 2, 2021 · 5 comments · Fixed by #1584
Closed

throughput & iops options for managed node_groups when create_launch_template=true #1567

etsuo opened this issue Sep 2, 2021 · 5 comments · Fixed by #1584

Comments

@etsuo
Copy link

etsuo commented Sep 2, 2021

Is your request related to a new offering from AWS?

AWS provider's aws_launch_template supports iops and throughput when volume_type is gp3.

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_template

This appears to have been implemented for worker_groups (#1444).

Is your request related to a problem? Please describe.

I could implement my own launch template and utilize launch_template_id -- but it would be easier to simply provide optional disk_iops and disk_throughput inputs like disk_type.

Describe the solution you'd like.

module "eks" {
  ...
  node_groups = {
    example = {
      ...
      disk_type = "gp3"
      disk_throughput = "500"
      disk_iops = "4000"
    }
  }
}

Describe alternatives you've considered.

I could choose to not use create_launch_template=true and provide my own launch template per the example here: https://github.com/terraform-aws-modules/terraform-aws-eks/tree/master/examples/launch_templates_with_managed_node_groups

@etsuo etsuo changed the title throughout & iops options for managed node_groups when create_launch_template=true throughput & iops options for managed node_groups when create_launch_template=true Sep 2, 2021
@daroga0002
Copy link
Contributor

@etsuo do you will be able to create PR for this. I attached #1445 as example of way how this was done for worker_groups

@junaid-ali
Copy link
Contributor

@daroga0002 I can work on this if no one has picked this up.

@daroga0002
Copy link
Contributor

@daroga0002 I can work on this if no one has picked this up.

I didnt seen PR so you can work on it and 🙏

@daroga0002 daroga0002 added the wip label Sep 6, 2021
@etsuo
Copy link
Author

etsuo commented Sep 8, 2021

Thanks @daroga0002 and @junaid-ali

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants