Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] self managed node groups volume size #2027

Closed
aliartiza75 opened this issue Apr 20, 2022 · 4 comments
Closed

[Question] self managed node groups volume size #2027

aliartiza75 opened this issue Apr 20, 2022 · 4 comments

Comments

@aliartiza75
Copy link
Contributor

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

  • No 🛑: please wait to file a request until the functionality is avaialble in the AWS provider
  • Yes ✅: please list the AWS provider version which introduced this functionality

Is your request related to a problem? Please describe.

There are two ways in the self manage node groups main.tf file, which can be used to specify the size of the volume for a node group.

  1. Method 1: disk_size

  2. Method 2: block_device_mappings

After looking at the node_groups.tf and self_managed_node_group module file. I am assuming that it is not being used anywhere.

Secondly, in method 1 I don't have options to change volume specifications i.e encryption, volume type, etc.

I have 2 questions:

  1. What is the purpose of disk_size?
  2. if we can create a volume using the block_device_mappings param then is it necessary to keep disk_size in the example because it is causing confusion?

Describe the solution you'd like.

I think only 1 method should be used to specify the size of the volume because only disk_size doesn't provide much flexibility.

Describe alternatives you've considered.

NIL

Additional context

NIL

@bryantbiggs
Copy link
Member

I think this might be a copy+paste error in the example. disk_size is only available for EKS managed node groups - let me investigate and double check

@aliartiza75
Copy link
Contributor Author

@bryantbiggs sure. Another suggestion:

It would be good to add this in the examples provided.

@bryantbiggs
Copy link
Member

The use of disk_size in examples was updated in #2034

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants