Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow setting metadata endpoint options so users can configure or disable #2132

Closed
scotthesterberg opened this issue Jun 30, 2022 · 9 comments · Fixed by #2133
Closed

Comments

@scotthesterberg
Copy link

Can we get this fix back-ported to this repo: aws-ia/terraform-aws-eks-blueprints#657 ? It would be useful for the same reasons it was implemented for the AWS EKS Blueprints repo.

Allow setting metadata endpoint options so users can configure or disable.

Motivation

Allow users to configure the metadata endpoint options to suit their workloads, or even disable if not supported in their region

@scotthesterberg scotthesterberg changed the title Fix Allow setting metadata endpoint options so users can configure or disable Fix: Allow setting metadata endpoint options so users can configure or disable Jun 30, 2022
@bryantbiggs
Copy link
Member

This is already supported in this module

@scotthesterberg
Copy link
Author

scotthesterberg commented Jun 30, 2022

I do not believe it is. There is currently no way to fully disable setting the metadata_options. I have attempted setting metadata_options = null and Terraform still attempts to set the metadata. In some AWS deployments this is not currently supported. This is why the enable_metadata_options flag was implemented in the referenced PR.

@bryantbiggs
Copy link
Member

do you have a reproduction I can look at

@bryantbiggs
Copy link
Member

after investigating, it looks like our conditional check against null is incorrect. PR coming soon

@scotthesterberg
Copy link
Author

Awesome, thank you so much!

@antonbabenko
Copy link
Member

This issue has been resolved in version 18.26.2 🎉

@bryantbiggs
Copy link
Member

@scotthesterberg this should be resolved now by setting metadata_options = {} , let me know if you run into any issues

@scotthesterberg
Copy link
Author

@bryantbiggs Thanks I really appreciate it!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants