Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 18.26.2, bad type introduced for fargate_profile.iam_role_additional_policies #2142

Closed
philicious opened this issue Jul 5, 2022 · 3 comments · Fixed by #2143

Comments

@philicious
Copy link
Contributor

Description

in #2133 you changed the fallback in try(...) 2d7701c#diff-f18568a32bfa70d11a736400eff74d8c51858b9fcbb8af637c14d94c3562a431R221 from list to map, which doesnt fit the type in the fargate module

type = list(string)
default = []

Versions

  • Module version [Required]: 18.26.2

Reproduction Code [Required]

  fargate_profiles = {
    default = {
      name = "default"
      selectors = [
        {
          namespace = "kube-system"
        }
      ]
    }
  }

Steps to reproduce the behavior:

Create EKS with at least one fargate profile

Expected behavior

it works

Actual behavior

it fails

│ on .terraform/modules/eks.eks/terraform-aws-eks-18.26.2/node_groups.tf line 221, in module "fargate_profile":
│ 221: iam_role_additional_policies = try(each.value.iam_role_additional_policies, var.fargate_profile_defaults.iam_role_additional_policies, {})

│ The given value is not suitable for child module variable "iam_role_additional_policies" defined at
│ .terraform/modules/eks.eks/terraform-aws-eks-18.26.2/modules/fargate-profile/variables.tf:71,1-40: list of string required.

Additional context

Workaround by using <18.26.2 or explicitly setting an empty list so the try() doesnt resort to fallback

fargate_profile_defaults = {
    iam_role_additional_policies = []
  }
@bryantbiggs
Copy link
Member

Duplicate of #2136

@antonbabenko
Copy link
Member

This issue has been resolved in version 18.26.3 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants