Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set a custom policy name AND separate custom role name for karpenter IRSA #2465

Closed
patrickleet opened this issue Feb 9, 2023 · 5 comments · Fixed by #2480
Closed

Comments

@patrickleet
Copy link
Contributor

patrickleet commented Feb 9, 2023

Is your request related to a new offering from AWS?

No

Is your request related to a problem? Please describe.

I need to be able to set the policy name separately to the role name. You can currently provide a name that is used for the role AND the policy via irsa_name, but you can not set a separate name for each. Due to my organization requirements I need to be able to name each of them separately.

Describe the solution you'd like.

#2480

Describe alternatives you've considered.

It's a minor change, and makes sense in this module. I don't want to use a different solution.

Additional context

@gwilsonco
Copy link

This would be a useful feature given our org policies.

@curtisnn
Copy link

Our org requires this type of solution. Would be helpful for us.

@sabarnath
Copy link

Yes, we too have a strong policy to enforce that every role/policy name should be prefixed with the given value.
So current default naming have violating the policy and automatically get deleted. Kindly approve it.

@antonbabenko
Copy link
Member

This issue has been resolved in version 19.10.0 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants