Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module.eks.eks_managed_node_groups.core.node_group_status returns wrong parameter #2519

Closed
1 task done
dfroberg opened this issue Mar 15, 2023 · 2 comments · Fixed by #2524
Closed
1 task done

module.eks.eks_managed_node_groups.core.node_group_status returns wrong parameter #2519

dfroberg opened this issue Mar 15, 2023 · 2 comments · Fixed by #2524

Comments

@dfroberg
Copy link

Description

When looking up the node_group status the node group ARN is returned instead.

If your request is for a new feature, please use the Feature request template.

  • ✋ I have searched the open/closed issues and my issue is not listed.

Versions

  • Module version [Required]:
    19.10
  • Terraform version:
    Terraform v1.3.9
  • Provider version(s):
  • provider registry.terraform.io/gavinbunney/kubectl v1.14.0
  • provider registry.terraform.io/grafana/grafana v1.35.0
  • provider registry.terraform.io/hashicorp/aws v4.56.0
  • provider registry.terraform.io/hashicorp/cloudinit v2.3.2
  • provider registry.terraform.io/hashicorp/helm v2.9.0
  • provider registry.terraform.io/hashicorp/kubernetes v2.18.1
  • provider registry.terraform.io/hashicorp/local v2.4.0
  • provider registry.terraform.io/hashicorp/null v3.2.1
  • provider registry.terraform.io/hashicorp/random v3.4.3
  • provider registry.terraform.io/hashicorp/time v0.9.1
  • provider registry.terraform.io/hashicorp/tls v4.0.4
  • provider registry.terraform.io/terraform-aws-modules/http v2.4.1
  • provider registry.terraform.io/viktorradnai/bcrypt v0.1.2

Reproduction Code [Required]

tags = merge(local.tags, {
    "core_status"    = module.eks.eks_managed_node_groups.core.node_group_status == "ACTIVE" ? "ready" : "not-ready"
  })

Steps to reproduce the behavior:

Expected behavior

A string return with node group status i.e., ACTIVE

Actual behavior

The node group ARN is returned.

Terminal Output Screenshot(s)

Additional context

The error is caused by the module output pointing to the wrong parameter in
modules/eks_managed_node_group/modules/eks-managed-node-group/outputs.tf#L38-L39

output "node_group_status" {
  description = "Status of the EKS Node Group"
  value       = try(aws_eks_node_group.this[0].arn, null)
}

Should instead be;

output "node_group_status" {
  description = "Status of the EKS Node Group"
  value       = try(aws_eks_node_group.this[0].status, null)
}
@antonbabenko
Copy link
Member

This issue has been resolved in version 19.10.1 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants