Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag_specifications to ASG created by eks_managed_nodegroup #3022

Closed
not-ajay opened this issue Apr 30, 2024 · 4 comments
Closed

Add tag_specifications to ASG created by eks_managed_nodegroup #3022

not-ajay opened this issue Apr 30, 2024 · 4 comments

Comments

@not-ajay
Copy link

Currently the tag_specifications in ASG created by eks_managed_nodegroup has only instance and volume, i need to add 2 more to this, how can i do this for the ASG launch template created by eks_managed_nodegroup :

I tested by using custom launch template and providing below in eks_managed_node_group_defaults :
tag_specifications = ["instance", "volume", "network-interface", "spot-instances-request"]

Same i want in the launch template for ASG which is created by eks_managed_nodegroup.

Any help is apreciated :)

@not-ajay
Copy link
Author

not-ajay commented May 1, 2024

@bryantbiggs Can you take a look and suggest ?

@bryantbiggs
Copy link
Member

There are variables for this

variable "tag_specifications" {
description = "The tags to apply to the resources during launch"
type = list(string)
default = ["instance", "volume", "network-interface"]
}

@not-ajay
Copy link
Author

not-ajay commented May 9, 2024

Hey @bryantbiggs , Eventhough i have added the tag_specifications variable with required resources, it doesnt seem to be propagated to the launch template created by eks managed nodegroup.

I took help of AWS support and found this issue in open at their end : aws/containers-roadmap#1496

Copy link

github-actions bot commented Jun 9, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants