Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Redundant ignore_changes element #403

Closed
colvint opened this issue May 25, 2022 · 4 comments
Closed

Warning: Redundant ignore_changes element #403

colvint opened this issue May 25, 2022 · 4 comments

Comments

@colvint
Copy link

colvint commented May 25, 2022

ignore_changes = [
latest_restorable_time
]

Triggers this warning now:

╷
│ Warning: Redundant ignore_changes element
│ 
│   on .terraform/modules/master/modules/db_instance/main.tf line 26, in resource "aws_db_instance" "this":
│   26: resource "aws_db_instance" "this" {
│ 
│ Adding an attribute name to ignore_changes tells Terraform to ignore future
│ changes to the argument in configuration after the object has been created,
│ retaining the value originally configured.
│ 
│ The attribute latest_restorable_time is decided by the provider alone and
│ therefore there can be no configured value to compare with. Including this
│ attribute in ignore_changes has no effect. Remove the attribute from
│ ignore_changes to quiet this warning.

Using the latest terraform-aws-modules/rds/aws version.

@bryantbiggs
Copy link
Member

This is due to the latest version of Terraform v1.2 and we don't have any control over this at the moment

@antonbabenko any thoughts on what to do with these (I know there are others coming up terraform-aws-modules/terraform-aws-eks#2081)

@antonbabenko
Copy link
Member

#401 was about the same. This issue can be closed as a duplicate.

5 days ago I have forwarded this issue to someone handling the Terraform priorities at HashiCorp. Maybe they will come up with some clever solution for this.

Meanwhile, I think we need to live with this warning, unfortunately. I don't know how we can write code for both versions: <1.2 and >=1.2.

@bryantbiggs
Copy link
Member

#401 was about the same. This issue can be closed as a duplicate.

I knew I saw another issue somewhere, didn't think to check the issues here 😅

Meanwhile, I think we need to live with this warning, unfortunately. I don't know how we can write code for both versions: <1.2 and >=1.2.

I agree. The ignore changes were added based on prior issues and now we have warnings to remove those changes - I'm not sure where the disconnect is happening. For now, we'll close out as duplicate of #401

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants