Add a package-lock.json or yarn.lock

[romain-trotard]

Hello :)

It's me again.

What happened:

When I tried to make a reproduction test in this repository, I encounter some difficulties with the dependencies because there is not lock files. Moreover, because there are some libraries overrides this is buggy.

Reproduction:

Follow CONTRIBUTING.md, i.e. :

• Clone the repo
• npm run setup -s

See the error with browserslist.

Problem description:

Because there is no lock files, the latest libraries are fetched. Unfortunately babel made some change on their @babel/helper-compilation-targets that pull the latest browserslist package which expose a new findConfigFile (which is not exposed in the override version)

In the issue #1352 I had to do this to make the test reproduction works:

https://github.com/romain-trotard/dom-testing-library/blob/labelledby-multiple-repro/package.json#L83

Suggested solution:

I know that Kent is not fond of pushing lock files kentcdodds/kcd-scripts#22 (comment).

But I wonder why it would be a problem to do it.

I think pushing it, would help a lot on the reproducibility.

Thanks in advance :)

[github-actions]

Uh oh! @romain-trotard, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.