Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link to code of conduct #173

Closed
RoystonS opened this issue Dec 8, 2018 · 2 comments
Closed

Broken link to code of conduct #173

RoystonS opened this issue Dec 8, 2018 · 2 comments
Labels
documentation An update needs to be made to documentation

Comments

@RoystonS
Copy link
Contributor

RoystonS commented Dec 8, 2018

The CODE_OF_CONDUCT.md file is referenced from a badge in README.md, which expects the file to be in the repository root, but the file is actually in the other directory. So the link is broken.

Either the link is wrong or the location is wrong. react-testing-library puts this file in the repo root.

Suggested solution:

Move CODE_OF_CONDUCT.md from other to the repo root?

(I was about to submit a PR for this, thinking the file was absent, but then I found it in other so I backed off and raised this issue instead.)
@kentcdodds
Copy link
Member

Yeah, I think the file should be moved.

@alexkrolick alexkrolick added the documentation An update needs to be made to documentation label Dec 9, 2018
@RoystonS
Copy link
Contributor Author

RoystonS commented Dec 9, 2018

Fix in pull #175

@RoystonS RoystonS closed this as completed Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation An update needs to be made to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RoystonS @kentcdodds @alexkrolick