-
Notifications
You must be signed in to change notification settings - Fork 147
/
Copy pathno-debugging-utils.ts
193 lines (170 loc) · 4.89 KB
/
no-debugging-utils.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
import { ASTUtils, TSESTree, JSONSchema } from '@typescript-eslint/utils';
import { createTestingLibraryRule } from '../create-testing-library-rule';
import {
getDeepestIdentifierNode,
getFunctionName,
getInnermostReturningFunction,
getPropertyIdentifierNode,
getReferenceNode,
isCallExpression,
isObjectPattern,
isProperty,
} from '../node-utils';
import { DEBUG_UTILS } from '../utils';
type DebugUtilsToCheckFor = Partial<
Record<typeof DEBUG_UTILS[number], boolean>
>;
export const RULE_NAME = 'no-debugging-utils';
export type MessageIds = 'noDebug';
type Options = [{ utilsToCheckFor?: DebugUtilsToCheckFor }];
export default createTestingLibraryRule<Options, MessageIds>({
name: RULE_NAME,
meta: {
type: 'problem',
docs: {
description: 'Disallow the use of debugging utilities like `debug`',
recommendedConfig: {
dom: false,
angular: 'warn',
react: 'warn',
vue: 'warn',
marko: 'warn',
},
},
messages: {
noDebug: 'Unexpected debug statement',
},
schema: [
{
type: 'object',
properties: {
utilsToCheckFor: {
type: 'object',
properties: DEBUG_UTILS.reduce<
Record<string, JSONSchema.JSONSchema7>
>(
(obj, name) => ({
[name]: { type: 'boolean' },
...obj,
}),
{}
),
additionalProperties: false,
},
},
additionalProperties: false,
},
],
},
defaultOptions: [
{ utilsToCheckFor: { debug: true, logTestingPlaygroundURL: true } },
],
create(context, [{ utilsToCheckFor = {} }], helpers) {
const suspiciousDebugVariableNames: string[] = [];
const suspiciousReferenceNodes: TSESTree.Identifier[] = [];
const renderWrapperNames: string[] = [];
const builtInConsoleNodes: TSESTree.VariableDeclarator[] = [];
const utilsToReport = Object.entries(utilsToCheckFor)
.filter(([, shouldCheckFor]) => shouldCheckFor)
.map(([name]) => name);
function detectRenderWrapper(node: TSESTree.Identifier): void {
const innerFunction = getInnermostReturningFunction(context, node);
if (innerFunction) {
renderWrapperNames.push(getFunctionName(innerFunction));
}
}
return {
VariableDeclarator(node) {
if (!node.init) {
return;
}
const initIdentifierNode = getDeepestIdentifierNode(node.init);
if (!initIdentifierNode) {
return;
}
if (initIdentifierNode.name === 'console') {
builtInConsoleNodes.push(node);
return;
}
const isRenderWrapperVariableDeclarator = renderWrapperNames.includes(
initIdentifierNode.name
);
if (
!helpers.isRenderVariableDeclarator(node) &&
!isRenderWrapperVariableDeclarator
) {
return;
}
// find debug obtained from render and save their name, like:
// const { debug } = render();
if (isObjectPattern(node.id)) {
for (const property of node.id.properties) {
if (
isProperty(property) &&
ASTUtils.isIdentifier(property.key) &&
utilsToReport.includes(property.key.name)
) {
const identifierNode = getDeepestIdentifierNode(property.value);
if (identifierNode) {
suspiciousDebugVariableNames.push(identifierNode.name);
}
}
}
}
// find utils kept from render and save their node, like:
// const utils = render();
if (ASTUtils.isIdentifier(node.id)) {
suspiciousReferenceNodes.push(node.id);
}
},
CallExpression(node) {
const callExpressionIdentifier = getDeepestIdentifierNode(node);
if (!callExpressionIdentifier) {
return;
}
if (helpers.isRenderUtil(callExpressionIdentifier)) {
detectRenderWrapper(callExpressionIdentifier);
}
const referenceNode = getReferenceNode(node);
const referenceIdentifier = getPropertyIdentifierNode(referenceNode);
if (!referenceIdentifier) {
return;
}
const isDebugUtil = helpers.isDebugUtil(
callExpressionIdentifier,
utilsToReport as Array<typeof DEBUG_UTILS[number]>
);
const isDeclaredDebugVariable = suspiciousDebugVariableNames.includes(
callExpressionIdentifier.name
);
const isChainedReferenceDebug = suspiciousReferenceNodes.some(
(suspiciousReferenceIdentifier) => {
return (
utilsToReport.includes(callExpressionIdentifier.name) &&
suspiciousReferenceIdentifier.name === referenceIdentifier.name
);
}
);
const isVariableFromBuiltInConsole = builtInConsoleNodes.some(
(variableDeclarator) => {
const variables = context.getDeclaredVariables(variableDeclarator);
return variables.some(
({ name }) =>
name === callExpressionIdentifier.name &&
isCallExpression(callExpressionIdentifier.parent)
);
}
);
if (
!isVariableFromBuiltInConsole &&
(isDebugUtil || isDeclaredDebugVariable || isChainedReferenceDebug)
) {
context.report({
node: callExpressionIdentifier,
messageId: 'noDebug',
});
}
},
};
},
});