Skip to content

Commit 7ed3da8

Browse files
MichaelDeBoeyMichaelDeBoey
authored
feat(no-await-sync-query): rename to no-await-sync-queries (#666)
BREAKING CHANGE: `no-await-sync-query` is now called `no-await-sync-queries`
1 parent e394ce0 commit 7ed3da8

File tree

10 files changed

+15
-15
lines changed

10 files changed

+15
-15
lines changed

‎README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ Then configure the rules you want to use within `rules` property of your `.eslin
6868
{
6969
"rules": {
7070
"testing-library/await-async-query": "error",
71-
"testing-library/no-await-sync-query": "error",
71+
"testing-library/no-await-sync-queries": "error",
7272
"testing-library/no-debugging-utils": "warn",
7373
"testing-library/no-dom-import": "off"
7474
}
@@ -211,7 +211,7 @@ To enable this configuration use the `extends` property in your
211211
| [`await-async-utils`](./docs/rules/await-async-utils.md) | Enforce promises from async utils to be awaited properly | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
212212
| [`consistent-data-testid`](./docs/rules/consistent-data-testid.md) | Ensures consistent usage of `data-testid` | | |
213213
| [`no-await-sync-events`](./docs/rules/no-await-sync-events.md) | Disallow unnecessary `await` for sync events | | |
214-
| [`no-await-sync-query`](./docs/rules/no-await-sync-query.md) | Disallow unnecessary `await` for sync queries | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
214+
| [`no-await-sync-queries`](./docs/rules/no-await-sync-queries.md) | Disallow unnecessary `await` for sync queries | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
215215
| [`no-container`](./docs/rules/no-container.md) | Disallow the use of `container` methods | | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
216216
| [`no-debugging-utils`](./docs/rules/no-debugging-utils.md) | Disallow the use of debugging utilities like `debug` | | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
217217
| [`no-dom-import`](./docs/rules/no-dom-import.md) | Disallow importing from DOM Testing Library | 🔧 | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |

‎docs/rules/no-await-sync-query.md ‎docs/rules/no-await-sync-queries.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Disallow unnecessary `await` for sync queries (`testing-library/no-await-sync-query`)
1+
# Disallow unnecessary `await` for sync queries (`testing-library/no-await-sync-queries`)
22

33
Ensure that sync queries are not awaited unnecessarily.
44

‎lib/configs/angular.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export = {
1111
],
1212
'testing-library/await-async-query': 'error',
1313
'testing-library/await-async-utils': 'error',
14-
'testing-library/no-await-sync-query': 'error',
14+
'testing-library/no-await-sync-queries': 'error',
1515
'testing-library/no-container': 'error',
1616
'testing-library/no-debugging-utils': 'warn',
1717
'testing-library/no-dom-import': ['error', 'angular'],

‎lib/configs/dom.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export = {
1111
],
1212
'testing-library/await-async-query': 'error',
1313
'testing-library/await-async-utils': 'error',
14-
'testing-library/no-await-sync-query': 'error',
14+
'testing-library/no-await-sync-queries': 'error',
1515
'testing-library/no-global-regexp-flag-in-query': 'error',
1616
'testing-library/no-node-access': 'error',
1717
'testing-library/no-promise-in-fire-event': 'error',

‎lib/configs/marko.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export = {
1111
],
1212
'testing-library/await-async-query': 'error',
1313
'testing-library/await-async-utils': 'error',
14-
'testing-library/no-await-sync-query': 'error',
14+
'testing-library/no-await-sync-queries': 'error',
1515
'testing-library/no-container': 'error',
1616
'testing-library/no-debugging-utils': 'warn',
1717
'testing-library/no-dom-import': ['error', 'marko'],

‎lib/configs/react.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export = {
1111
],
1212
'testing-library/await-async-query': 'error',
1313
'testing-library/await-async-utils': 'error',
14-
'testing-library/no-await-sync-query': 'error',
14+
'testing-library/no-await-sync-queries': 'error',
1515
'testing-library/no-container': 'error',
1616
'testing-library/no-debugging-utils': 'warn',
1717
'testing-library/no-dom-import': ['error', 'react'],

‎lib/configs/vue.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export = {
1111
],
1212
'testing-library/await-async-query': 'error',
1313
'testing-library/await-async-utils': 'error',
14-
'testing-library/no-await-sync-query': 'error',
14+
'testing-library/no-await-sync-queries': 'error',
1515
'testing-library/no-container': 'error',
1616
'testing-library/no-debugging-utils': 'warn',
1717
'testing-library/no-dom-import': ['error', 'vue'],

‎lib/rules/no-await-sync-query.ts ‎lib/rules/no-await-sync-queries.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { TSESTree } from '@typescript-eslint/utils';
33
import { createTestingLibraryRule } from '../create-testing-library-rule';
44
import { getDeepestIdentifierNode } from '../node-utils';
55

6-
export const RULE_NAME = 'no-await-sync-query';
6+
export const RULE_NAME = 'no-await-sync-queries';
77
export type MessageIds = 'noAwaitSyncQuery';
88
type Options = [];
99

‎tests/__snapshots__/index.test.ts.snap

+5-5
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Object {
1515
],
1616
"testing-library/await-async-query": "error",
1717
"testing-library/await-async-utils": "error",
18-
"testing-library/no-await-sync-query": "error",
18+
"testing-library/no-await-sync-queries": "error",
1919
"testing-library/no-container": "error",
2020
"testing-library/no-debugging-utils": "warn",
2121
"testing-library/no-dom-import": Array [
@@ -50,7 +50,7 @@ Object {
5050
],
5151
"testing-library/await-async-query": "error",
5252
"testing-library/await-async-utils": "error",
53-
"testing-library/no-await-sync-query": "error",
53+
"testing-library/no-await-sync-queries": "error",
5454
"testing-library/no-global-regexp-flag-in-query": "error",
5555
"testing-library/no-node-access": "error",
5656
"testing-library/no-promise-in-fire-event": "error",
@@ -80,7 +80,7 @@ Object {
8080
],
8181
"testing-library/await-async-query": "error",
8282
"testing-library/await-async-utils": "error",
83-
"testing-library/no-await-sync-query": "error",
83+
"testing-library/no-await-sync-queries": "error",
8484
"testing-library/no-container": "error",
8585
"testing-library/no-debugging-utils": "warn",
8686
"testing-library/no-dom-import": Array [
@@ -116,7 +116,7 @@ Object {
116116
],
117117
"testing-library/await-async-query": "error",
118118
"testing-library/await-async-utils": "error",
119-
"testing-library/no-await-sync-query": "error",
119+
"testing-library/no-await-sync-queries": "error",
120120
"testing-library/no-container": "error",
121121
"testing-library/no-debugging-utils": "warn",
122122
"testing-library/no-dom-import": Array [
@@ -156,7 +156,7 @@ Object {
156156
],
157157
"testing-library/await-async-query": "error",
158158
"testing-library/await-async-utils": "error",
159-
"testing-library/no-await-sync-query": "error",
159+
"testing-library/no-await-sync-queries": "error",
160160
"testing-library/no-container": "error",
161161
"testing-library/no-debugging-utils": "warn",
162162
"testing-library/no-dom-import": Array [

‎tests/lib/rules/no-await-sync-query.test.ts ‎tests/lib/rules/no-await-sync-queries.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import rule, { RULE_NAME } from '../../../lib/rules/no-await-sync-query';
1+
import rule, { RULE_NAME } from '../../../lib/rules/no-await-sync-queries';
22
import {
33
SYNC_QUERIES_COMBINATIONS,
44
ASYNC_QUERIES_COMBINATIONS,

0 commit comments

Comments
 (0)