Skip to content

Commit 8f1e313

Browse files
authored
Merge branch 'main' into pr/await-async-events-rule-validates-userevent-session
2 parents 8ba464f + 05e94fa commit 8f1e313

8 files changed

+140
-88
lines changed

.all-contributorsrc

+20
Original file line numberDiff line numberDiff line change
@@ -639,6 +639,26 @@
639639
"test",
640640
"doc"
641641
]
642+
},
643+
{
644+
"login": "maisano",
645+
"name": "Richard Maisano",
646+
"avatar_url": "https://avatars.githubusercontent.com/u/689081?v=4",
647+
"profile": "https://github.com/maisano",
648+
"contributions": [
649+
"code",
650+
"test"
651+
]
652+
},
653+
{
654+
"login": "doochik",
655+
"name": "Aleksei Androsov",
656+
"avatar_url": "https://avatars.githubusercontent.com/u/31961?v=4",
657+
"profile": "https://github.com/doochik",
658+
"contributions": [
659+
"code",
660+
"test"
661+
]
642662
}
643663
],
644664
"contributorsPerLine": 7,

.github/workflows/pipeline.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
uses: actions/checkout@v4
3434

3535
- name: Use Node
36-
uses: actions/setup-node@v3
36+
uses: actions/setup-node@v4
3737
with:
3838
node-version-file: '.nvmrc'
3939

@@ -61,7 +61,7 @@ jobs:
6161
uses: actions/checkout@v4
6262

6363
- name: Use Node
64-
uses: actions/setup-node@v3
64+
uses: actions/setup-node@v4
6565
with:
6666
node-version: ${{ matrix.node }}
6767

@@ -90,7 +90,7 @@ jobs:
9090
uses: actions/checkout@v4
9191

9292
- name: Use Node
93-
uses: actions/setup-node@v3
93+
uses: actions/setup-node@v4
9494
with:
9595
node-version-file: '.nvmrc'
9696

.github/workflows/smoke-test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
uses: actions/checkout@v4
1616

1717
- name: Use Node
18-
uses: actions/setup-node@v3
18+
uses: actions/setup-node@v4
1919
with:
2020
node-version-file: '.nvmrc'
2121

README.md

+2
Original file line numberDiff line numberDiff line change
@@ -425,6 +425,8 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
425425
<td align="center" valign="top" width="14.28%"><a href="https://github.com/nathanmmiller"><img src="https://avatars.githubusercontent.com/u/37555055?v=4?s=100" width="100px;" alt="Nathan"/><br /><sub><b>Nathan</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=nathanmmiller" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=nathanmmiller" title="Tests">⚠️</a></td>
426426
<td align="center" valign="top" width="14.28%"><a href="https://github.com/justintoman"><img src="https://avatars.githubusercontent.com/u/11649507?v=4?s=100" width="100px;" alt="justintoman"/><br /><sub><b>justintoman</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=justintoman" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=justintoman" title="Tests">⚠️</a></td>
427427
<td align="center" valign="top" width="14.28%"><a href="https://github.com/adevick"><img src="https://avatars.githubusercontent.com/u/106642175?v=4?s=100" width="100px;" alt="Anthony Devick"/><br /><sub><b>Anthony Devick</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=adevick" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=adevick" title="Tests">⚠️</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=adevick" title="Documentation">📖</a></td>
428+
<td align="center" valign="top" width="14.28%"><a href="https://github.com/maisano"><img src="https://avatars.githubusercontent.com/u/689081?v=4?s=100" width="100px;" alt="Richard Maisano"/><br /><sub><b>Richard Maisano</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=maisano" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=maisano" title="Tests">⚠️</a></td>
429+
<td align="center" valign="top" width="14.28%"><a href="https://github.com/doochik"><img src="https://avatars.githubusercontent.com/u/31961?v=4?s=100" width="100px;" alt="Aleksei Androsov"/><br /><sub><b>Aleksei Androsov</b></sub></a><br /><a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=doochik" title="Code">💻</a> <a href="https://github.com/testing-library/eslint-plugin-testing-library/commits?author=doochik" title="Tests">⚠️</a></td>
428430
</tr>
429431
</tbody>
430432
</table>

lib/rules/no-manual-cleanup.ts

+4-7
Original file line numberDiff line numberDiff line change
@@ -111,15 +111,12 @@ export default createTestingLibraryRule<Options, MessageIds>({
111111
return {
112112
'Program:exit'() {
113113
const testingLibraryImportName = helpers.getTestingLibraryImportName();
114-
const testingLibraryImportNode = helpers.getTestingLibraryImportNode();
115114
const customModuleImportNode = helpers.getCustomModuleImportNode();
116115

117-
if (
118-
testingLibraryImportName &&
119-
testingLibraryImportNode &&
120-
testingLibraryImportName.match(CLEANUP_LIBRARY_REGEXP)
121-
) {
122-
reportCandidateModule(testingLibraryImportNode);
116+
if (testingLibraryImportName?.match(CLEANUP_LIBRARY_REGEXP)) {
117+
for (const importNode of helpers.getAllTestingLibraryImportNodes()) {
118+
reportCandidateModule(importNode);
119+
}
123120
}
124121

125122
if (customModuleImportNode) {

package-lock.json

+80-77
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)